Files: 
CommentFileSizeAuthor
#19 views-core-rename-sort-options-2003246-19.patch1.05 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,148 pass(es). View
#19 interdiff.txt717 bytesnathangervais
#16 interdiff.txt717 bytesnathangervais
#16 views-core-rename-sort-options-2003246-13.patch1.04 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,226 pass(es). View
#14 views-core-rename-sort-options-2003246-13.patch1.04 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,164 pass(es). View
#12 views-core-sortOptions-2003246-12.patch1.03 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] 55,622 pass(es), 1 fail(s), and 0 exception(s). View
#7 2003246-7449576-2.patch1.03 KBendorn
PASSED: [[SimpleTest]]: [MySQL] 55,755 pass(es). View
#5 2003246-7449576.patch1.02 KBendorn
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

farfanfelipe’s picture

Assigned:Unassigned» farfanfelipe
endorn’s picture

Assigned:farfanfelipe» endorn
endorn’s picture

Assigned:endorn» Unassigned
endorn’s picture

Assigned:Unassigned» endorn
endorn’s picture

FileSize
1.02 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

renamed function names.

endorn’s picture

Status:Active» Needs review
endorn’s picture

FileSize
1.03 KB
PASSED: [[SimpleTest]]: [MySQL] 55,755 pass(es). View

forgot to add public.

hoZt’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003246-7449576-2.patch, failed testing.

endorn’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#7: 2003246-7449576-2.patch queued for re-testing.

oenie’s picture

Status:Needs review» Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

SpartyDan’s picture

Status:Needs work» Needs review
FileSize
1.03 KB
FAILED: [[SimpleTest]]: [MySQL] 55,622 pass(es), 1 fail(s), and 0 exception(s). View

re-rolled

Status:Needs review» Needs work

The last submitted patch, views-core-sortOptions-2003246-12.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
FileSize
1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 57,164 pass(es). View

patch 12 no longer applies.

re-rolled

aspilicious’s picture

Status:Needs review» Needs work

Should be protected

=> protected function sortOptions() {

nathangervais’s picture

Assigned:endorn» nathangervais
Status:Needs work» Needs review
FileSize
1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 57,226 pass(es). View
717 bytes

Here's the old patch with an interdiff to add the protected access modifier.

aspilicious’s picture

Status:Needs review» Needs work

Patch odesn't contain the access modifier

dcam’s picture

It looks like the same patch from #13 was mistakenly re-uploaded.

nathangervais’s picture

Status:Needs work» Needs review
FileSize
717 bytes
1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,148 pass(es). View

Apologies I had thought i was supposed to supply the original patch with the interdiff. Here's the new patch with the interdiff.

dcam’s picture

It's no problem. The interdiff just shows the change you made between the old patch and the new one so that it's easy for reviewers to see the changes that you've made.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Perfect!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed eb60f6f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.