Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#10 views-core-usesExposed-2002942-10.patch1.75 KBSpartyDan
#8 2002942-08-views-uses_exposed.patch1.75 KBSpartyDan
#4 2002942-04-views-uses_exposed.patch1.74 KBSpartyDan
#2 vdc-2002942.patch1.09 KBjastraat

Comments

jastraat’s picture

jastraat commented
Assigned: Unassigned » jastraat
jastraat’s picture

jastraat commented
Status: Active » Needs review
StatusFileSize
new vdc-2002942.patch1.09 KB

Status: Needs review » Needs work

The last submitted patch, vdc-2002942.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
StatusFileSize
new 2002942-04-views-uses_exposed.patch1.74 KB

On line 212 of /views/Plugin/views/display/DisplayPluginBase.php there is an instance of uses_exposed that the patch did not update.

Here is a new patch.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review

I am changing to needs review because I forgot to change the status when I uploaded the new patch.

Status: Needs review » Needs work

The last submitted patch, 2002942-04-views-uses_exposed.patch, failed testing.

aspilicious’s picture

aspilicious commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -245,7 +245,7 @@ function exposed_form_validate(&$form, &$form_state) { }
+  function usesExposed() {

Cab you add public to the function.

==> Public function usesExposed().

(both places)

Btw I think this is a terrible name doesn't tell me anything. What is exposed in a pager?

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new 2002942-08-views-uses_exposed.patch1.75 KB

keyword public added to function.

oenie’s picture

oenie commented
Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-usesExposed-2002942-10.patch1.75 KB

re-rolled

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8cf5b02 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.