Files: 
CommentFileSizeAuthor
#12 views-valueForm-2002932-12.patch10.71 KBvito_a
PASSED: [[SimpleTest]]: [MySQL] 55,853 pass(es). View
#7 views-valueForm-2002932-7.patch9.7 KBzschmid
FAILED: [[SimpleTest]]: [MySQL] 55,604 pass(es), 2 fail(s), and 1 exception(s). View
#4 views-valueForm-2002932-4.patch12.23 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 56,907 pass(es). View
#2 vdc-2002932.patch10.17 KBjastraat
PASSED: [[SimpleTest]]: [MySQL] 55,712 pass(es). View

Comments

jastraat’s picture

Assigned: Unassigned » jastraat
jastraat’s picture

Status: Active » Needs review
FileSize
10.17 KB
PASSED: [[SimpleTest]]: [MySQL] 55,712 pass(es). View
aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/BooleanOperator.phpundefined
@@ -100,7 +100,7 @@ function operator_form(&$form, &$form_state) {
+  function valueForm(&$form, &$form_state) {

These should all be protected. ==> protected function valueForm()

zschmid’s picture

Status: Needs work » Needs review
FileSize
12.23 KB
PASSED: [[SimpleTest]]: [MySQL] 56,907 pass(es). View

updated patch

zschmid’s picture

Assigned: jastraat » Unassigned
aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/search/lib/Drupal/search/Plugin/views/filter/Search.phpundefined
--- /dev/null
+++ b/core/modules/system/system.module.rejundefined

+++ b/core/modules/system/system.module.rejundefined
+++ b/core/modules/system/system.module.rejundefined
@@ -0,0 +1,25 @@

@@ -0,0 +1,25 @@
+diff a/core/modules/system/system.module b/core/modules/system/system.module	(rejected hunks)
+@@ -882,7 +886,7 @@ function system_menu() {
+     'weight' => -10,
+     'file' => 'system.admin.inc',
+   );
+-  $items['admin/config/regional/date-time/formats/%system_date_format/edit'] = array(
++  $items['admin/config/regional/settings/date-time/formats/%system_date_format/edit'] = array(
+     'title' => 'Edit date format',
+     'description' => 'Allow users to edit a configured date format.',
+     'page callback' => 'drupal_get_form',
+@@ -890,12 +894,12 @@ function system_menu() {
+     'access arguments' => array('administer site configuration'),
+     'file' => 'system.admin.inc',
+   );
+-  $items['admin/config/regional/date-time/formats/%system_date_format/delete'] = array(
++  $items['admin/config/regional/settings/date-time/formats/%system_date_format/delete'] = array(
+     'title' => 'Delete date format',
+     'description' => 'Allow users to delete a configured date format.',
+     'route_name' => 'date_format_delete',
+   );
+-  $items['admin/config/regional/date-time/formats/lookup'] = array(
++  $items['admin/config/regional/settings/date-time/formats/lookup'] = array(
+     'title' => 'Date and time lookup',
+     'page callback' => 'system_date_time_lookup',

This shouldn't be here :)

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.phpundefined
@@ -95,7 +95,7 @@ public function buildExtraOptionsForm(&$form, &$form_state) {
+  function valueForm(&$form, &$form_state) {

protected

zschmid’s picture

FileSize
9.7 KB
FAILED: [[SimpleTest]]: [MySQL] 55,604 pass(es), 2 fail(s), and 1 exception(s). View

Crap. Sorry about those extra files, must have forgotten to switch branches before this. Anywayss, i think it needed to be rerolled anyways after the core commits yesterday/today. Should be okay now.

zschmid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views-valueForm-2002932-7.patch, failed testing.

E.Kurko’s picture

Issue tags: +CodeSprintUA

I'll check. CodeSprintUA

E.Kurko’s picture

Assigned: Unassigned » E.Kurko

Assigned to me

vito_a’s picture

Assigned: E.Kurko » vito_a
FileSize
10.71 KB
PASSED: [[SimpleTest]]: [MySQL] 55,853 pass(es). View

Re-rolling the #7.

vito_a’s picture

Status: Needs work » Needs review
vito_a’s picture

Assigned: vito_a » Unassigned
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect

webchick’s picture

Title: Rename Views method value_form() to valueForm() » Change notice: Rename Views method value_form() to valueForm()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title: Change notice: Rename Views method value_form() to valueForm() » Rename Views method value_form() to valueForm()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.