Files: 
CommentFileSizeAuthor
#6 rename_views_method-2002930-6.patch3.19 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 55,939 pass(es).
[ View ]
#6 interdiff.txt2.8 KBmarlatt
#2 rename_valueValidate-2002930-2.patch3.17 KBmarlatt
Test request sent.
[ View ]
#1 rename_valueValidate-2002930-1.patch1.85 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] 55,724 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

markie’s picture

Assigned:Unassigned» markie
Status:Active» Needs review
StatusFileSize
new1.85 KB
FAILED: [[SimpleTest]]: [MySQL] 55,724 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

patched.. but not the taxonomy module. (function exists there)

marlatt’s picture

StatusFileSize
new3.17 KB
Test request sent.
[ View ]

Included additional instances of method changes and added public method changes.

markie’s picture

do we want to modify a different module in this change? I am cool with the public access addition, but don't want to step on other modules toes.

markie’s picture

I take this back. I realize now they are extending a views class here. Please disregard the silly monkey.

aspilicious’s picture

Status:Needs review» Needs work

This is a function only used internally by filter plugins. I would use "protected" in that case.

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new2.8 KB
new3.19 KB
PASSED: [[SimpleTest]]: [MySQL] 55,939 pass(es).
[ View ]

Revised methods from public to protected.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

No calls are left, patch applies and looks fine.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 7731380 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.