Files: 
CommentFileSizeAuthor
#21 2002920-rename-get_items_per_page.patch7.73 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 56,617 pass(es).
[ View ]
#16 2002920-rename-get_items_per_page.patch7.72 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002920-rename-get_items_per_page_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#14 2002920-rename-get_items_per_page.patch7.7 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 56,655 pass(es).
[ View ]
#12 views.module-rename_get_items_per_page-2002920-12.patch7.86 KBMaxis
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views.module-rename_get_items_per_page-2002920-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#9 2002920-9.patch7.71 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002920-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 2002920-get_items_per_page-conversion.patch7.61 KBPsikik
PASSED: [[SimpleTest]]: [MySQL] 55,718 pass(es).
[ View ]

Comments

Psikik’s picture

Assigned:Unassigned» Psikik
Psikik’s picture

Assigned:Psikik» Unassigned
Status:Active» Needs review
StatusFileSize
new7.61 KB
PASSED: [[SimpleTest]]: [MySQL] 55,718 pass(es).
[ View ]

Convert get_items_per_page function to getItemsPerPage and add public decorator.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002920-get_items_per_page-conversion.patch, failed testing.

nielsonm’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 2002920-get_items_per_page-conversion.patch, failed testing.

oenie’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/2002920-get_items_per_page-conversion_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7797  100  7797    0     0  14510      0 --:--:-- --:--:-- --:--:-- 21538
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/pager/Mini.php:79
error: core/modules/views/lib/Drupal/views/Plugin/views/pager/Mini.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.php:277
error: core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new7.71 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002920-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 2002920-9.patch, failed testing.

Maxis’s picture

Assigned:Unassigned» Maxis
Issue tags:+CodeSprintUA

start working

Maxis’s picture

Status:Needs work» Needs review
StatusFileSize
new7.86 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views.module-rename_get_items_per_page-2002920-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

bot?

Status:Needs review» Needs work

The last submitted patch, views.module-rename_get_items_per_page-2002920-12.patch, failed testing.

sillygwailo’s picture

Status:Needs work» Needs review
StatusFileSize
new7.7 KB
PASSED: [[SimpleTest]]: [MySQL] 56,655 pass(es).
[ View ]

The patch applied with -p0 but not the standard -p1. Re-rolling. This patch should at least apply.

oenie’s picture

Status:Needs review» Needs work

Oops ... seems we've missed an access modifier here, my bad, should have noticed this before:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/None.phpundefined
@@ -71,7 +71,7 @@ function use_count_query() {
+  function getItemsPerPage() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -68,7 +68,7 @@
+  function getItemsPerPage() {

Add public access modifier in front of the functions to adhere to the new OOP standards.

sillygwailo’s picture

StatusFileSize
new7.72 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002920-rename-get_items_per_page_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolled with public.

sillygwailo’s picture

Status:Needs work» Needs review
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
aspilicious’s picture

Issue tags:-Novice, -VDC, -CodeSprintUA

Status:Reviewed & tested by the community» Needs work
Issue tags:+Novice, +VDC, +CodeSprintUA

The last submitted patch, 2002920-rename-get_items_per_page.patch, failed testing.

sillygwailo’s picture

Status:Needs work» Needs review
StatusFileSize
new7.73 KB
PASSED: [[SimpleTest]]: [MySQL] 56,617 pass(es).
[ View ]

Now that renaming set_offset() has been committed, this one should apply.

sillygwailo’s picture

A note that #2003282: Rename Views method set_items_per_page() to setItemsPerPage() is related to this. In that issue, the lines patched refer to get_items_per_page() and will have to be updated to getItemsPerPage. That issue has a simpler patch than this one, but it may not matter, as long as one goes before the other.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

#21 looks good to me. All instances of get_items_per_page() are rewritten. The public access modifier has been added to all getItemsPerPage() methods.

#2003282: Rename Views method set_items_per_page() to setItemsPerPage() will need a reroll if this is committed.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 52befbe and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.