Rename Views method get_items_per_page() to getItemsPerPage()

Convert get_items_per_page function to getItemsPerPage and add public decorator.

#2: 2002920-get_items_per_page-conversion.patch queued for re-testing.

#2: 2002920-get_items_per_page-conversion.patch queued for re-testing.

Looks fine to me now !

Needs a re-roll

curl http://drupal.org/files/2002920-get_items_per_page-conversion_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7797  100  7797    0     0  14510      0 --:--:-- --:--:-- --:--:-- 21538
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/pager/Mini.php:79
error: core/modules/views/lib/Drupal/views/Plugin/views/pager/Mini.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.php:277
error: core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.php: patch does not apply

reroll. Had conflict with #1998330: Minipager is broken on page size == 1 due to ceil(PHP_MAX_INT / 1)

start working

bot?

The patch applied with -p0 but not the standard -p1. Re-rolling. This patch should at least apply.

Oops ... seems we've missed an access modifier here, my bad, should have noticed this before:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/None.phpundefined
@@ -71,7 +71,7 @@ function use_count_query() {
+  function getItemsPerPage() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -68,7 +68,7 @@
+  function getItemsPerPage() {

Add public access modifier in front of the functions to adhere to the new OOP standards.

Re-rolled with public.

#16: 2002920-rename-get_items_per_page.patch queued for re-testing.

Now that renaming set_offset() has been committed, this one should apply.

A note that #2003282: Rename Views method set_items_per_page() to setItemsPerPage() is related to this. In that issue, the lines patched refer to get_items_per_page() and will have to be updated to getItemsPerPage. That issue has a simpler patch than this one, but it may not matter, as long as one goes before the other.

#21 looks good to me. All instances of get_items_per_page() are rewritten. The public access modifier has been added to all getItemsPerPage() methods.

#2003282: Rename Views method set_items_per_page() to setItemsPerPage() will need a reroll if this is committed.

Committed 52befbe and pushed to 8.x. Thanks!