Improve code maintainability by removing unused local variables - core/includes/update.inc

Sorry, didn't see it was already assigned.

• Removed $method_id key from foreach statement on line 441
• Removed $conf on line 630
• Removed $default_data on line 1509

Sorry about duplicating your effort, Froelund; I didn't refresh my browser before uploading the patch. If you would like to review my patch then we can resolve the confusion.

See reviewing patches on drupal.org

Removing blank line looks better for me (#2).
I'd also rather remove $default_data as in #3.

So, combined effort would do it.

I thought about removing the variable $default_data, and just read the data from the file directly , but I think it is better for readability to "name" what we are applying, by naming it as the variable $default_data instead.

How about removing comment then? Things become obvious with that variable.

Good idea, I'll supply a new patch.

I disagree with #6, the point of these patches is to get rid of unnecessary and unused variables. There is no need to create that variable and unnecessarily use extra memory IMO. Here is a patch that combines the goodness of #2 and #3.

Looks good! Thanks guys.

#10: 8.x-unused-vars-2002732-10.patch queued for re-testing.

looking good

Committed 0979e1f and pushed to 8.x. Thanks!