See meta #2002650: [meta] improve maintainability by removing unused local variables

core/includes/install.inc

  • Unused local variable $kernel (line 620)
Files: 
CommentFileSizeAuthor
#2 performance-2002722.patch595 bytesneochief
PASSED: [[SimpleTest]]: [MySQL] 55,764 pass(es).
[ View ]

Comments

neochief’s picture

Assigned:Unassigned» neochief
neochief’s picture

Status:Active» Needs review
StatusFileSize
new595 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,764 pass(es).
[ View ]
neochief’s picture

Removed whole block, because it was used to assign to useless variable.

Sam Moore’s picture

Assigned:neochief» Sam Moore
Status:Needs review» Active

I'm working on this.

Sam Moore’s picture

Assigned:Sam Moore» Unassigned

Sorry, race condition w/ neochief. Have backed off.

kerasai’s picture

Status:Active» Needs review

#2: performance-2002722.patch queued for re-testing.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Looks ok and testbot agrees

tim.plunkett’s picture

Status:Reviewed & tested by the community» Needs review
Issue tags:+Stalking Crell

Um, hm. I'm not so sure about this. It is possible that the act of get()ing it instantiates it, which might be important. Either way, checking with Crell.

katbailey’s picture

Status:Needs review» Reviewed & tested by the community

The kernel is a synthetic service, which means that if the container has it, then it has been instantiated (the container does not know how to instantiate it). This is just leftover from before Fabian's patch here: http://drupalcode.org/project/drupal.git/blobdiff/0f90bee2e179acf17fd489...

alexpott’s picture

Title:Improve performance by removing unused local variables - core/includes/install.inc» Improve maintainability by removing unused local variables - core/includes/install.inc
Status:Reviewed & tested by the community» Fixed

Committed a4295b6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.