Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.See meta #2002650: [meta, no patch] improve maintainability by removing unused local variables
core/includes/install.inc
- Unused local variable $kernel (line 620)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | performance-2002722.patch | 595 bytes | neochief |
Comments
Comment #1
neochief commentedComment #2
neochief commentedComment #3
neochief commentedRemoved whole block, because it was used to assign to useless variable.
Comment #4
sam mooreI'm working on this.
Comment #5
sam mooreSorry, race condition w/ neochief. Have backed off.
Comment #6
kerasai commented#2: performance-2002722.patch queued for re-testing.
Comment #7
aspilicious commentedLooks ok and testbot agrees
Comment #8
tim.plunkettUm, hm. I'm not so sure about this. It is possible that the act of get()ing it instantiates it, which might be important. Either way, checking with Crell.
Comment #9
katbailey commentedThe kernel is a synthetic service, which means that if the container has it, then it has been instantiated (the container does not know how to instantiate it). This is just leftover from before Fabian's patch here: http://drupalcode.org/project/drupal.git/blobdiff/0f90bee2e179acf17fd489...
Comment #10
alexpottCommitted a4295b6 and pushed to 8.x. Thanks!