Files: 
CommentFileSizeAuthor
#13 drupal-views_method_rename-2002462-13.patch1.08 KBdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 56,553 pass(es). View
#9 views-method_rename-2002462-9.patch16.61 KBdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es). View
#5 Rename_Views_method-2002462-5.patch16.79 KBNonProfit
None View
#2 Rename_Views_method-2002462-2.patch13.35 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

NonProfit’s picture

Assigned: Unassigned » NonProfit
NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
13.35 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch created.

NonProfit’s picture

Assigned: Unassigned » NonProfit
Status: Needs review » Needs work

Need to reroll. default_summary_form() improperly changed.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -768,7 +768,7 @@ function process_summary_arguments(&$args) {
+  function defaultSummary() {

Add public access modifier in front of the function to adher to the new OOP standards.

NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Needs work » Needs review
FileSize
16.79 KB
None View

Patch created.

heddn’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -768,7 +768,7 @@ function process_summary_arguments(&$args) {
+  function defaultSummary() {

I think need to be protected.

Also needs a re-roll:
$ git apply --index Rename_Views_method-2002462-5.patch
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:462
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:353
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
error: patch failed: core/modules/views/tests/views_test_config/test_views/views.view.test_aggregate_count.yml:14
error: core/modules/views/tests/views_test_config/test_views/views.view.test_aggregate_count.yml: patch does not apply
error: patch failed: core/modules/views/tests/views_test_config/test_views/views.view.test_destroy.yml:34
error: core/modules/views/tests/views_test_config/test_views/views.view.test_destroy.yml: patch does not apply

danylevskyi’s picture

Assigned: Unassigned » danylevskyi
danylevskyi’s picture

Issue tags: +CodeSprintUA
danylevskyi’s picture

FileSize
16.61 KB
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es). View
danylevskyi’s picture

Assigned: danylevskyi » Unassigned
Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -462,7 +462,7 @@ function default_actions($which = NULL) {
-        'method' => 'default_summary',
+        'method' => 'defaultSummary',

This change is fine.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -562,7 +562,7 @@ public function defaultArgumentForm(&$form, &$form_state) {
-  public function defaultSummaryForm(&$form, &$form_state) {
+  protected function defaultSummaryForm(&$form, &$form_state) {

Please skip this chage.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -768,7 +768,7 @@ function process_summary_arguments(&$args) {
-  function default_summary() {
+  function defaultSummary() {

the method should be protected.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/DefaultSummary.phpundefined
@@ -17,7 +17,7 @@
- *   id = "default_summary",
+ *   id = "defaultSummary",

This ID of the plugin should be kept, so please skip all the other changes in all the files.

danylevskyi’s picture

Assigned: Unassigned » danylevskyi
danylevskyi’s picture

Assigned: danylevskyi » Unassigned
Status: Needs work » Needs review
FileSize
1.08 KB
PASSED: [[SimpleTest]]: [MySQL] 56,553 pass(es). View
podarok’s picture

Status: Needs review » Reviewed & tested by the community

#13 looks good
RTBC

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

Title: Rename Views method default_summary() to defaultSummary() » Change notice: Rename Views method default_summary() to defaultSummary()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Fixed » Active
Issue tags: +Needs change record

Oops.

xjm’s picture

Title: Change notice: Rename Views method default_summary() to defaultSummary() » Rename Views method default_summary() to defaultSummary()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.