Files: 
CommentFileSizeAuthor
#11 views-rename_build_sort-20088-11.patch4.56 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,475 pass(es).
[ View ]
#4 views-rename_build_sort-2002388-4.patch5.38 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,602 pass(es).
[ View ]
#2 views.core-rename_build_sort-2002388-02.patch6.18 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] 55,694 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

toddtomlinson’s picture

Assigned:Unassigned» toddtomlinson
toddtomlinson’s picture

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new6.18 KB
FAILED: [[SimpleTest]]: [MySQL] 55,694 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Patch renames build_sort to buildSort.

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -373,7 +373,7 @@ function wizard_submit(&$form, &$form_state, WizardInterface $wizard, &$display_
+  function buildSort() { return TRUE; }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -103,7 +103,7 @@ protected function defineOptions() {
+  function buildSort() {

Add public access modifier in front of the functions to adher to the new OOP standards.

JeroenT’s picture

Status:Needs work» Needs review
StatusFileSize
new5.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,602 pass(es).
[ View ]
oenie’s picture

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-rename_build_sort-2002388-4.patch, failed testing.

JeroenT’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
dawehner’s picture

So we rename vars and functions at the same time?

aspilicious’s picture

Status:Needs review» Needs work

No that is out of scope :)

somepal’s picture

except variables are renamed too!

JeroenT’s picture

Status:Needs work» Needs review
StatusFileSize
new4.56 KB
PASSED: [[SimpleTest]]: [MySQL] 55,475 pass(es).
[ View ]

Only renamed the build_sort function.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Thank you. Code looks fine, there is no other call and patch applies.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-rename_build_sort-20088-11.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
dcam’s picture

Status:Needs review» Reviewed & tested by the community

#11 still applies and was already RTBC in #12.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed e41c6e1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.