Files: 
CommentFileSizeAuthor
#11 views.core-rename_build_form-2002374-11.patch3.04 KBbrentaar
PASSED: [[SimpleTest]]: [MySQL] 55,959 pass(es). View
#8 views.core-rename_build_form-2002374-08.patch3.04 KBbrentaar
PASSED: [[SimpleTest]]: [MySQL] 55,818 pass(es). View
#5 views.core-rename_build_form-2002374-05.patch1.53 KBbrentaar
FAILED: [[SimpleTest]]: [MySQL] 56,460 pass(es), 163 fail(s), and 64 exception(s). View
#2 views.core-rename_build_form-2002374-02.patch1.52 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

toddtomlinson’s picture

Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
FileSize
1.52 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

patch to rename build_form attached.

jameswoods’s picture

Renamed code looks good to me.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardInterface.phpundefined
@@ -26,7 +26,7 @@
+  function buildForm(array $form, array &$form_state);

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -198,9 +198,9 @@ public function getSorts() {
+  function buildForm(array $form, array &$form_state) {

Add public access modifier in front of the functions to adher to the new OOP standards.

brentaar’s picture

FileSize
1.53 KB
FAILED: [[SimpleTest]]: [MySQL] 56,460 pass(es), 163 fail(s), and 64 exception(s). View

added public and re-rolled.

brentaar’s picture

Status: Needs work » Needs review
oenie’s picture

Status: Needs review » Needs work

It seems some occurrences have been missed:

core/modules/views/lib/Drupal/views/Tests/Wizard/WizardPluginBaseUnitTest.php, line 62:
$form = $this->wizard->build_form($form, $form_state);

core/modules/views_ui/lib/Drupal/views_ui/ViewAddFormController.php, line 153:
$form = $wizard_instance->build_form($form, $form_state);

brentaar’s picture

Status: Needs work » Needs review
FileSize
3.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,818 pass(es). View
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -198,9 +198,9 @@ public function getSorts() {
-   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::build_form().
+   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::buildForm().

Should be {@inheritdoc} instead of Implements...

brentaar’s picture

Status: Needs work » Needs review
FileSize
3.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,959 pass(es). View

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views.core-rename_build_form-2002374-11.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views.core-rename_build_form-2002374-11.patch, failed testing.

brentaar’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b0d6b2a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.