Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 May 2013 at 03:20 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
toddtomlinson commentedComment #2
toddtomlinson commentedpatch to rename build_form attached.
Comment #3
jameswoods commentedRenamed code looks good to me.
Comment #4
oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #5
brentaar commentedadded public and re-rolled.
Comment #6
brentaar commentedComment #7
oenie commentedIt seems some occurrences have been missed:
core/modules/views/lib/Drupal/views/Tests/Wizard/WizardPluginBaseUnitTest.php, line 62:
$form = $this->wizard->build_form($form, $form_state);core/modules/views_ui/lib/Drupal/views_ui/ViewAddFormController.php, line 153:
$form = $wizard_instance->build_form($form, $form_state);Comment #8
brentaar commentedComment #9
oenie commentedLooks good to me now !
Comment #10
alexpottShould be
{@inheritdoc}instead ofImplements...Comment #11
brentaar commentedComment #13
heddn#11: views.core-rename_build_form-2002374-11.patch queued for re-testing.
Comment #15
brentaar commented#11: views.core-rename_build_form-2002374-11.patch queued for re-testing.
Comment #16
oenie commentedLooks good to me now !
Comment #17
alexpottCommitted b0d6b2a and pushed to 8.x. Thanks!