Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#11 | views.core-rename_build_form-2002374-11.patch | 3.04 KB | brentaar |
#8 | views.core-rename_build_form-2002374-08.patch | 3.04 KB | brentaar |
#5 | views.core-rename_build_form-2002374-05.patch | 1.53 KB | brentaar |
#2 | views.core-rename_build_form-2002374-02.patch | 1.52 KB | toddtomlinson |
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
toddtomlinson CreditAttribution: toddtomlinson commentedpatch to rename build_form attached.
Comment #3
jameswoods CreditAttribution: jameswoods commentedRenamed code looks good to me.
Comment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #5
brentaar CreditAttribution: brentaar commentedadded public and re-rolled.
Comment #6
brentaar CreditAttribution: brentaar commentedComment #7
oenie CreditAttribution: oenie commentedIt seems some occurrences have been missed:
core/modules/views/lib/Drupal/views/Tests/Wizard/WizardPluginBaseUnitTest.php, line 62:
$form = $this->wizard->build_form($form, $form_state);
core/modules/views_ui/lib/Drupal/views_ui/ViewAddFormController.php, line 153:
$form = $wizard_instance->build_form($form, $form_state);
Comment #8
brentaar CreditAttribution: brentaar commentedComment #9
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #10
alexpottShould be
{@inheritdoc}
instead ofImplements...
Comment #11
brentaar CreditAttribution: brentaar commentedComment #13
heddn#11: views.core-rename_build_form-2002374-11.patch queued for re-testing.
Comment #15
brentaar CreditAttribution: brentaar commented#11: views.core-rename_build_form-2002374-11.patch queued for re-testing.
Comment #16
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #17
alexpottCommitted b0d6b2a and pushed to 8.x. Thanks!