Files: 
CommentFileSizeAuthor
#8 2002370-8.patch1.29 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,316 pass(es). View
#2 views.core-rename_build_display_options-2002370-02.patch1.29 KBtoddtomlinson
PASSED: [[SimpleTest]]: [MySQL] 57,348 pass(es). View

Comments

toddtomlinson’s picture

Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
FileSize
1.29 KB
PASSED: [[SimpleTest]]: [MySQL] 57,348 pass(es). View

Rolled patch that renames build_display_options attached.

jameswoods’s picture

Renamed functions look good to me.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views.core-rename_build_display_options-2002370-02.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/views.core-rename_build_display_options-2002370-02.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1323  100  1323    0     0   3641      0 --:--:-- --:--:-- --:--:--  7037
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:649
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
1.29 KB
PASSED: [[SimpleTest]]: [MySQL] 56,316 pass(es). View

reroll

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
somepal’s picture

second review.gtg

webchick’s picture

Title: Rename Views method build_display_options() to buildDisplayOptions() » Change notice: Rename Views method build_display_options() to buildDisplayOptions()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

Title: Change notice: Rename Views method build_display_options() to buildDisplayOptions() » Rename Views method build_display_options() to buildDisplayOptions()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.