The default animation for modal is show(). Without animationSpeed setting show() would display the modal immediately. However modal doesn't allow animationSpeed to be empty. If animationSpeed is empty it is set to fast(). This is probably because empty values would cause errors but it also has the side effect of preventing 0 as speed which could be used to skip animations.

CommentFileSizeAuthor
#1 ctools_allow_0_animspeed-2001360-1.patch228 byteskimwes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kimwes’s picture

kimwes CreditAttribution: kimwes commented
Status: Active » Needs review
FileSize
ctools_allow_0_animspeed-2001360-1.patch228 bytes

Here's a patch that preserves the current behaviour of setting fast to animSpeed when it's empty but it also allows 0 to be set.

DamienMcKenna queued 1: ctools_allow_0_animspeed-2001360-1.patch for re-testing.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Issue summary: View changes

The 6 year old patch to modal.js applied cleanly to the latest ctools 7.x-1.x-dev, but still needs to be officially reviewed and tested by the community.

Checking patch js/modal.js...
Hunk #1 succeeded at 378 (offset 32 lines).
Applied patch js/modal.js cleanly.
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs review » Fixed

Very reasonable request, sorry for the delay. I've committed this to the latest -dev release. Thanks @kimwes

  • joelpittet committed b361ee5 on 7.x-1.x authored by kimwes 
    Issue #2001360 by kimwes, Chris2: Allow modal animationSpeed to be 0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.