Thanks for this great module.

While using this to convert Chinese into Pinyin, I found some bugs.

Here is the patch.

I would like also to request a co-maintainer for this module. To fix the inssues and mainly the Chinese problem.

As there are thousand of words on Chinese and we do need time check to fix them. If I were a co-maintainer , I can fix them directly.

Thanks for your attention.

CommentFileSizeAuthor
#8 transliteration-chinesebug-1998782-8.patch1.24 KBedxxu
chinese_patch.patch3.73 KBzterry95

Comments

rogical’s picture

rogical commented

the default translation does not working well, it's good to have someone to improve this.

lcnphp’s picture

lcnphp commented

Great Job!

jackniu’s picture

jackniu commented

This problem has troubled me for a long time, thanks!

Good job!

zterry95’s picture

zterry95 commented
Project: Transliteration » Drupal.org site moderators
Version: 7.x-3.x-dev »
Component: Miscellaneous » Project ownership

I would like to request an co-maintainer for this module.

The last commits of this module is 10 months ago.
https://drupal.org/node/199246/commits

Also my patch in this tickets get no response more than 2 weeks.

I will help in fix the mistakes in Chinese and other problem in the inssue list.

Thanks for your attention.

dddave’s picture

dddave commented
Project: Drupal.org site moderators » Transliteration
Version: » 7.x-3.x-dev
Component: Project ownership » Code

I'm sending this back into the module queue so that this issue can still be found there and so that people can actually review the patch.

I would recommend to file a new issue in Transliterations queue requesting co-maintainership and contacting the maintainers of the module directly per mail. After two weeks with no response to that effort you can send that issue into the webmaster queue.

amateescu’s picture

amateescu commented
Status: Active » Fixed

Committed and pushed to 7.x-3.x and 6.x-3.x. Thanks and sorry for not replying sooner!

http://drupalcode.org/project/transliteration.git/commit/f44ee0a
http://drupalcode.org/project/transliteration.git/commit/31c0d96

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

edxxu’s picture

edxxu commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new transliteration-chinesebug-1998782-8.patch1.24 KB

I found a bug when transliterate simplifed chinese character '惊' into Pinyin. The result should be 'Jing' but 'Liang' instead.

Here is the patch, please review.

edxxu’s picture

edxxu commented

Here is the '惊' item in Chinese dictionary.

http://dict.baidu.com/s?wd=%E6%83%8A

chris matthews’s picture

chris matthews commented
Status: Needs review » Fixed

@edxxu, since this issue has already been committed and pushed to 7.x-3.x and 6.x-3.x, you'll need to open a new issue for #8.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.