Calling module_implements loads up files. We don't want to do this. Thus this needs to be cached.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

mikeytown2’s picture

Status: Active » Fixed
FileSize
863 bytes

Shaves ~10ms off of the request for an advagg cache hit. Following patch has been committed

mikeytown2’s picture

I've gotten this down to core: 7ms, advagg: 9ms using microtime(TRUE) timers. Using xdebug it shows core: 32ms, advagg: 42ms. ~30% slower when we are talking about 2ms isn't a big issue in my opinion. If I wanted to get more out of it I could cache advagg_merge_plans or _advagg_aggregate_css/js but that would give me a lower cache hit ratio for that cache due to inlined output. Nonetheless something to think about.

mikeytown2’s picture

By adding caching at the highest level I got this to be faster than core.
microtime: 4ms
xdebug: 17ms

I'll build a setting to turn caching on and off.

mikeytown2’s picture

The following patch has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.