Layout of social links a little off [#1996734]

On the full product display the social links does not look as good, as they could be. See attached screenshot.

Comment	File	Size	Author
#1	service_links_layout_1996734-1.patch	540 bytes	vasike
#7	Skærmbillede 2013-05-25 kl. 14.23.12.png	276.12 KB	lsolesen
#3	service_links_layout_1996734-2.patch	12.68 KB	Cookiz
	Skærmbillede 2013-05-16 kl. 23.15.24.png	259.52 KB	lsolesen

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vasike

Ramnicu Valcea

CreditAttribution: vasike commented 27 May 2013 at 06:59

Status:

Needs work

» Needs review

File	Size
service_links_layout_1996734-1.patch	540 bytes

indeed. it seems there's a fixed width for the social links items.
This is an issue of Omega Kickstart.
here is a patch for this.

Comment #2

lsolesen CreditAttribution: lsolesen commented 19 May 2013 at 13:51

Project:	Commerce Kickstart	» Omega Kickstart
Version:	7.x-2.6	» 7.x-3.x-dev
Status:	Active	» Needs work

Makes no difference. It is still the same after applying the patch.

Comment #3

Cookiz CreditAttribution: Cookiz commented 23 May 2013 at 16:08

File	Size
service_links_layout_1996734-2.patch	12.68 KB

Can you tried with this patch (I've simply remove the fixed width in the css).
I will include this modification in the theme if it works for you.

Comment #4

lsolesen CreditAttribution: lsolesen commented 25 May 2013 at 12:01

Status:

Needs work

» Needs review

Comment #5

lsolesen CreditAttribution: lsolesen commented 25 May 2013 at 12:24

I applied the patch and got the following:

$ git apply service_links_layout_1996734-2.patch
service_links_layout_1996734-2.patch:336: trailing whitespace.
    
warning: 1 line adds whitespace errors.

Also the output seems to be the same, see attached.

Comment #6

lsolesen CreditAttribution: lsolesen commented 25 May 2013 at 12:24

Status:

Needs review

» Needs work

Comment #7

lsolesen CreditAttribution: lsolesen commented 25 May 2013 at 12:25

File	Size
Skærmbillede 2013-05-25 kl. 14.23.12.png	276.12 KB

Comment #8

Cookiz CreditAttribution: Cookiz commented 30 May 2013 at 09:12

Status:

Needs review

» Closed (won't fix)

Okay so it seems the iframe for fb like button has settings (admin/config/services/service-links/widgets)
by default the width is set to 100px, because of the length of the like button in your language you will need to change the width to something like 160px.

The patch #2 will be included in the next omega_kickstart release (removing the width for the .service-links ul li).