Uncaught TypeError: Object #

has no method 'off' backbone-min.js:1
CommentFileSizeAuthor
#4 jqu_status_check-1992466-4.patch1.46 KBdesignerbrent

Comments

baddysonja’s picture

baddysonja
Primary language Icelandic
Location Frankfurt am Main
commented

I'm having the same error. Would be really nice if somebody could help out here

designerbrent’s picture

designerbrent commented

Exact same thing for me. Anyone know if there is a fix for this?

designerbrent’s picture

designerbrent commented
Version: 7.x-1.0-alpha10 » 7.x-1.x-dev
Priority: Major » Critical

This bug is active in both the dev and alpha10 versions of the module and makes it nearly unusable.

designerbrent’s picture

designerbrent commented
Status: Active » Needs review
StatusFileSize
new jqu_status_check-1992466-4.patch1.46 KB

The problem is that Backbone requires jQuery 1.7 or higher. This patch checks for jQuery_update and ensures that it is set to 1.7 or higher. If it is not, it gives a link to the settings page.

hass’s picture

hass commented

Per maintainer jquery update requirement has been explicitly removed a few versions ago. See https://drupal.org/node/1976064#comment-7364788 and search the issue queue, please.

#2008244: jQuery update module with 1.8 jquery version is required
#1976064: jQuery Update should be a dependency (or, preferably, remove non jQuery 1.4 code)

hass’s picture

hass commented
Status: Needs review » Needs work

Code style is not Drupal like and translatable string contain bugs. We never use l() in translatable strings as example.

designerbrent’s picture

designerbrent commented
Status: Needs work » Closed (works as designed)

Feel free to disregard the patch. I got the same error as above, searched the issue queue and ended here. This patch was my attempt at being helpful and scratching my own itch.

I don't see the point in fixing the patch it seems the maintainer doesn't want to require jQuery update so I'm marking this as closed (works as designed).

hass’s picture

hass commented
Status: Closed (works as designed) » Needs work

The bug is not fixed

bkonetzny’s picture

bkonetzny commented

Had the same issue, seems this is fixed in dev: http://drupalcode.org/project/navbar.git/commit/b8d56ca

jessebeach’s picture

jessebeach commented
Issue summary: View changes
Issue tags: +rc-blocker

This code changed in the recent dev work. I just need to verify that the fix from July wasn't regressed.

jessebeach’s picture

jessebeach commented
Status: Needs work » Fixed

I've verified that the code changes referred to in http://drupalcode.org/project/navbar.git/commit/b8d56ca are still in place (although written slightly differently) in the most recent backported code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.