Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it updates the code to the new APIs/code style
Unfrozen changes Unfrozen because changes automated tests
CommentFileSizeAuthor
#7 1987738_7.patch2.26 KBmile23

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

ayelet_Cr commented
Status: Closed (won't fix) » Active
rabellamy’s picture

rabellamy commented
Assigned: Unassigned » rabellamy
partyka’s picture

partyka commented
Assigned: rabellamy » partyka
partyka’s picture

partyka commented

Per discussion with Crell, the following test is being removed as it is longer necessary due to the concept of load arguments being gone in the routing system:
menu-test/arguments/%menu_test_argument/%/explicit-arguments
menu-test/arguments/%menu_test_argument/%menu_test_other_argument/common-loader
menu-test/arguments/%/%menu_test_argument/different-loaders-1
menu-test/arguments/%menu_test_other_argument/%/different-loaders-2
menu-test/arguments/%/%/different-loaders-3
menu-test/arguments/%menu_test_argument/%
menu-test/arguments/%menu_test_argument/%/default
menu-test/arguments/%menu_test_argument/%/task

xjm’s picture

xjm
she/her
Primary language English
commented

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 1987738_7.patch2.26 KB

Fix'd.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Assigned: partyka » Unassigned
valthebald’s picture

valthebald
Location Sofia
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Updated issue summary (+Beta stage evaluation), changing to RTBC

valthebald’s picture

valthebald
Location Sofia
commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 1987738_7.patch, failed testing.

valthebald’s picture

valthebald
Location Sofia
commented
Issue tags: +Needs reroll, +SprintWeekend2015
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue tags: -Needs reroll

I just did a reroll and the patches are the same. So it just needs to update to match new behavior.

valthebald’s picture

valthebald
Location Sofia
commented

But I see that tests failed with the patch? Should it be adjusted?

Status: Needs work » Needs review

aspilicious queued 7: 1987738_7.patch for re-testing.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Testbot hickup it was

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1add901 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 1add901 on 8.0.x 
    Issue #1987738 by Mile23: Convert menu_test_callback() to a new style...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.