Convert config_sync() to a new style controller

First pass

#1: config-sync.patch queued for re-testing.

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,218 @@
+  ¶

Trailing whitespace

Postponing this on #1890784: Refactor configuration import and sync functions as that issue will result in significant changes to this patch

Code sprint note.

I am working on this issue.

Rerolled patch
corrected white space in lib/Drupal/config/Form/ConfigSync.php
corrected file removal of config.admin.inc

BIG THNX to Benjifisher http://drupal.org/user/683300 for lots of help and my team mate swiftsure for our 1st major contribution.. ;-)

The new file is missing :)
Ask for help on creating patches with new files!

Go for it!

Thnx aspilicious !
Here it is.

My n00b mistake has been corrected. Addition of whitespace in hunk has been removed.

Rebuilt the patch (nearly from scratch). Lets see how tests will pass.

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+    $this->config_admin_sync_form($form, $form_state);

Let's camelCase the method.

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+  private function config_admin_sync_form(array &$form, array &$form_state) {

I don't see why we need a helper function here ...

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+          'title' => t('View differences'),

t could be replaced by the translation manager.

Based on the above this needs work.

Patch changed according to #24. Thank you for the review.

+++ b/core/modules/config/config.routing.ymlundefined
@@ -22,3 +22,9 @@ config_import:
+  pattern: 'admin/config/development/sync'

Pattern should start with a slash.

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+   *
+   * @var \Drupal\Core\StringTranslation\TranslationManager
...
+   * @param \Drupal\Core\StringTranslation\TranslationManager
...
+  public function __construct(StorageInterface $sourceStorage, StorageInterface $targetStorage, LockBackendInterface $lock, EventDispatcherInterface $event_dispatcher, ConfigFactory $config_factory, EntityManager $entity_manger, TranslationManager $translation_manager) {

I would vote to go with the TranslatorInterface

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+          'href' => 'admin/config/development/sync/diff/' . $config_file,

For now we could use getPathFromRoute on the url generator.

+++ b/core/modules/config/lib/Drupal/config/Form/ConfigSync.phpundefined
@@ -0,0 +1,246 @@
+  /**
+   * {@inheritdoc}
+   */
+  public function validateForm(array &$form, array &$form_state) {
+  }

Let's keep the usual order and move validateForm before submitForm

Rerolled patch.

Just in general this page is really nice with its diff functionality.

Committed 0adc91a and pushed to 8.x. Thanks!

-        // Return a negative result for UI purposes. We do not differentiate between
-        // an actual synchronization error and a failed lock, because concurrent
-        // synchronizations are an edge-case happening only when multiple developers
-        // or site builders attempt to do it without coordinating.
+        // Return a negative result for UI purposes. We do not differentiate
+        // between an actual synchronization error and a failed lock, because
+        // concurrent synchronizations are an edge-case happening only when
+        // multiple developers or site builders attempt to do it without
+        // coordinating.

Comment needed to be reformatted so that lines where less than 80 characters long.