Includes fix from: #1893752: Make sure that redirect module does not inject redirect into discount form
A couple typos.
Code cleanup and DCS compliance.
There is still some more code cleaning to do, but this is a start.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | patch_for_code_cleanup-1985668-7.patch | 5.66 KB | joelpittet |
| #4 | commerce_discount-multi-issue-patch-1985668-2.patch | 10.78 KB | jwjoshuawalker |
| #1 | commerce_discount-multi-issue-patch-1985668-1.patch | 15.22 KB | jwjoshuawalker |
Comments
Comment #1
jwjoshuawalker commentedattaching.
Comment #2
bojanz commentedI'll commit #1893752: Make sure that redirect module does not inject redirect into discount form separately, let's roll a patch without that.
Most of the code wrapping changes need to be reverted.
Please see http://drupal.org/coding-standards#linelength
There are multiple examples of this in your patch:
We never wrap variable declarations or function calls.
Comment #3
jwjoshuawalker commentedOk :(
I wish the codesniffer were more accurate in this regard. It does not flag an issue either way. I think that is just my personal preference, but I'll take those out where appropriate.
Comment #4
jwjoshuawalker commentedHere we go.
Comment #5
vasikethe (#4) patch needs a reroll.
Comment #6
jkuma commentedThanks for the code cleanup drastik, your patch will be committed after the alpha3.
Comment #7
joelpittetRe-roll of #4
Comment #8
joelpittetThanks, fixed and committed.