Before you say that this isn't OpenAtrium's problem :-) - I'd like to point out that lots and lots of people on Drupal.org depend on Simplytest.me in order to evaluate modules/distributions and test patches.

If you use the Dreditor browser plugin (which seems to be universal among Drupal core developers), it adds a "Simplytest.me" button to every module and patch - allowing you to quickly review the work of others.

For example, Pancho has posted a TON of patches in the issue queue recently. Yeah, I'll probably test one or two of them manually (apply the patch, install a site, etc). But if I could just click the blue "Simplytest.me" button next to the patch and test it, I'd review many more of them. At scale, this would get us from "Needs review" to "Needs work" or "RTBC" quicker.

Here is an issue from the Panopoly queue where they fixed the same problem:

#1956730: Rc3 fails testing with simplytest.me

Hopefully, that will provide insight into how to patch OpenAtrium! I'll submit a patch later. Unfortunately, without being able to commit to the Git repo, I can't test if the change actually works! But you can launch a site on Simplytest.me from a -dev release, so we will be able to test this ... slowly. :-)

Here is what looking at an issue with the Dreditor plugin looks like (for those who've never used it):

Selection_086.png

CommentFileSizeAuthor
#7 openatrium_build_make-1983280-7.patch550 bytespatrickd
#2 oa2-simplytestme-1983280-2.patch1.06 KBmpotter
Selection_086.png50.66 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: OpenAtrium profile work on Simplytest.me » OpenAtrium profile doesn't work on Simplytest.me

Fix my type-o in the title. :-)

mpotter’s picture

mpotter commented
Status: Active » Needs work
StatusFileSize
new oa2-simplytestme-1983280-2.patch1.06 KB

Weird, I must have an old version of dreditor. I only have the Review button.

In any case, when I follow the method described for Panopoly in OA2, it gets a bit weird because OA2 inherits from Panopoly. So with the above approach (and the patch attached here), the Panopoly files get placed within sites/profiles/openatrium, which is different from the structure created when the site is build from the drupal.org releases (where Panopoly is in sites/all/modules).

So I need some more help with this one. We need to find a method that generates the same site structure with Simplytest.me and with drupal.org.

(honestly, Simplytest.me really needs to update their code to work with the standard profile build structure being used on drupal.org!)

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

This sounds awesome, and I'm gonna take a look at it tonight, too.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

@mpotter: your patch gets the process further! Now it gets passed the profile selection screen BUT it chokes because the PHP imap extension isn't enabled on the simplytest.me server which causes it to get stuck on the requirements page. If mailhandler wasn't a dependency, this should fix that problem: #1986970: Make Mailhandler optional

beeradb’s picture

beeradb commented
Status: Needs work » Needs review

This should be tested again, now that #1986970: Make Mailhandler optional is fixed

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Comment from patrickd on this duplicate: #2022727: Add the profile itself to the build-openatrium.make file:

The problem is that the openatrium build-makefile is not following the common practices.

Profiles must specify them selfs in the build-[name].make file. (Eg. see the build-spark.make file)

build-openatrium.make currently:

api = 2
core = 7.x
includes[] = drupal-org-core.make
includes[] = drupal-org.make

But should be:

api = 2
core = 7.x
; Include the definition for how to build Drupal core directly, including patches:
includes[] = drupal-org-core.make
includes[] = drupal-org.make
; Download the OpenAtrium install profile and recursively build all its dependencies:
projects[openatrium][type] = profile
projects[openatrium][download][type] = git
projects[openatrium][download][branch] = 7.x-2.x

I'm not sure whether inheritance of profiles should be a problem (I certainly hope not).

Move to the OpenAtrium queue to see what they think about it

thanks for the report!

patrickd’s picture

patrickd commented
StatusFileSize
new openatrium_build_make-1983280-7.patch550 bytes

quick patch for the build-openatrium.make file to comply common practice

patrickd’s picture

patrickd commented

It takes quite a while until all the dependencies are fetched, but the patch seems to fix the problem and I was able to proceed to the installation.. but then it broke:

An AJAX HTTP error occurred.
HTTP Result Code: 200 Debugging information follows.
Path: http://sf6ff7929d9c136d.s3.simplytest.me/install.php?profile=openatrium&locale=en&id=1&op=do
StatusText: OK
ResponseText: Drupal @import url("http://sf6ff7929d9c136d.s3.simplytest.me/profiles/openatrium/openatrium.css?0"); Installation tasks
Choose profile(done)
Choose language(done)
Verify requirements(done)
Set up database(done)
Install profile(active)
Configure site
Verify Apps support
Install AppsChoose a themeFinished


Warning message The image resize filter has been installed. Before this does anything, the image resize filter needs to be added to one or more text formats. Visit the text format administration to set up this filter. You have enabled Mailhandler, but not any modules providing retrieval plugins (such as the Mailhandler PHP IMAP module). Without a retrieval plugin, Mailhandler is basically useless. Status message Now that you've enabled Mailhandler, you need to add a mailbox corresponding to an IMAP/POP3/mbox mailbox. To use menu blocks, find the "Add menu block" link on the administer blocks page. Content permissions have been rebuilt. SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'rid' cannot be null

I think this is a simplytest.me unspecific issue?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks! Your patch definitely allows OpenAtrium to get to the install stage for me, but it's still crashing on the "Mailhandler wanting the imap extension" thing. We'll have to remove that dependency as well (which unfortunately didn't happen in the #1986970: Make Mailhandler optional issue).

patrickd’s picture

patrickd commented

I really think we should commit the patch #7 anyway.

It won't mean that it suddenly starts working with simplytest.me but it's one step into the right direction and will definitely make openatrium follow the practices other distributions such as spark and com.kickstart are doing.

So if someone can take a look and RTBC it; afterwards we can look into the next issue as a followup

At least openatrium should add a proper requirement check before the installation begins, whether the needed extensions are available.

mpotter’s picture

mpotter commented
Status: Needs review » Fixed

Committed to e08087b.

The 'rid' cannot be null error is a different issue that there is another ticket on.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

@mpotter: Thanks, Mike! I just tested the 7.x-1.x branch and it worked BEAUTIFULLY! This will certainly help me in reviewing issues in the OA2 queue. :-)

@patrickd: Sorry, I didn't see your last message and mark the issue as RTBC! I definitely had reviewed it and tested it, but I just forgot to change the status. I hope that my lack of RTBC'ing this didn't contribute to the length of time it took to get committed. :-/ Anyway, it works now!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cravecode’s picture

cravecode commented
Version: 7.x-2.0-alpha2 » 7.x-2.60

Reopening, latest 7.x-2.60 doesn't work on simplytest.me.

cravecode’s picture

cravecode commented
Status: Closed (fixed) » Needs work
mpotter’s picture

mpotter commented
Status: Needs work » Closed (fixed)

Please open a new issue about this problem and post more details on the exact errors you are getting. This issue was for a patch that was already added and fixed 3 years ago. You should never re-open old stuff like this.