IN the HEAD version of the module it is still using a points field which has been changed to is_correct in some places, and left points in others. This patch will fix problems with quiz results.

CommentFileSizeAuthor
#8 quiz_is_correct_3.patch2.74 KBkylebrowning
#6 quiz_is_correct_2.patch2.17 KBkylebrowning
#3 quiz_is_correct.patch3.3 KBwestwesterson
quiz_head_variable.patch8.64 KBkylebrowning

Comments

westwesterson’s picture

westwesterson commented
Status: Needs review » Needs work

this patch has odd spacings in it, like spaces in the middle of words.... i would like to test it but cleaning it up might take a while...

kylebrowning’s picture

kylebrowning commented

I used diff on a linux machine to produce this patch, not Eclipse. Reason being is I wasnt working out of CVS to produce a diff against that. I will (if i find time today) Update this patch via a CVS diff.

Thanks.

westwesterson’s picture

westwesterson commented
StatusFileSize
new quiz_is_correct.patch3.3 KB

I have gone through and translated this patch against head. It took a while but it is still untested. I will test it later, but wanted to keep someone from doing the same work twice ;)

westwesterson’s picture

westwesterson commented

ok this patch definitely breaks the module, I can't edit or add questions, or take a quiz.

senpai’s picture

senpai commented
Title: Ths patch fixes is_correct variables » This patch fixes is_correct variables

If we can get this one re-rolled properly so that it applies to today's HEAD, it might also take care of 195896 as well. At least I think it does.

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new quiz_is_correct_2.patch2.17 KB

Here is an updated patch that will fix the quiz results.

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review
kylebrowning’s picture

kylebrowning commented
StatusFileSize
new quiz_is_correct_3.patch2.74 KB

Here is an updated patch that fixes both multichoice.module and quiz.module for this update

westwesterson’s picture

westwesterson commented

this looks like it might work. I remember points being replaced by is_correct, and this should clean up alot of the areas that were left behind. I will test soon, but the code looks much cleaner.

westwesterson’s picture

westwesterson commented
Status: Needs review » Fixed

tested and committed. Great patch thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

  • Commit c1b0d4e on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x by westwesterson: 
    fixes is_correct variables Issue #198252 by ocyrus

  • Commit c1b0d4e on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages by westwesterson: 
    fixes is_correct variables Issue #198252 by ocyrus

  • Commit c1b0d4e on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages, 2269219 by westwesterson: 
    fixes is_correct variables Issue #198252 by ocyrus

  • Commit c1b0d4e on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, 2269219 by westwesterson: 
    fixes is_correct variables Issue #198252 by ocyrus