Part of #1953410: [Meta] Remove field_create_*(), field_update_*() and field_delete_*() in favor of just using the ConfigEntity API

git diff 8.x core/modules/s* core/modules/u* core/modules/v* core/scripts >1981342-x.patch

Files: 
CommentFileSizeAuthor
#30 1981342-30.patch23.84 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 57,864 pass(es).
[ View ]
#25 interdiff.txt5.54 KBandypost
#25 1981342-25.patch23.84 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 57,804 pass(es).
[ View ]
#22 1981342-21.patch23.09 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.php.
[ View ]
#20 1981342-20.patch950 bytesaspilicious
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-20.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#18 1981342-18.patch23.09 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php.
[ View ]
#16 1981342-16.patch24.41 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-16.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#14 1981342-14.patch24.41 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-14.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#12 1981342-12.patch23.09 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php.
[ View ]
#10 1981342-10.patch23.09 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 1981342-8.patch91.24 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/field/lib/Drupal/field/Tests/CrudTest.php.
[ View ]
#7 1981342-7.patch18.18 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 55,373 pass(es).
[ View ]
#1 1953410-cud-1981342-1.patch18.65 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981342-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

andypost’s picture

Status:Active» Needs review
StatusFileSize
new18.65 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981342-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
andypost’s picture

Issue tags:+Novice

tagged to office hours

swentel’s picture

Status:Needs review» Closed (won't fix)

We're going todo this in one patch.

swentel’s picture

Status:Closed (won't fix)» Needs review

So we agreed to this in chunks anyway.

swentel’s picture

Issue tags:-Novice, -Field API

#1: 1953410-cud-1981342-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +Field API

The last submitted patch, 1953410-cud-1981342-1.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new18.18 KB
PASSED: [[SimpleTest]]: [MySQL] 55,373 pass(es).
[ View ]

rerolled

aspilicious’s picture

StatusFileSize
new91.24 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/field/lib/Drupal/field/Tests/CrudTest.php.
[ View ]

Reroll + some changes. Could fail...

Status:Needs review» Needs work

The last submitted patch, 1981342-8.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new23.09 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Hmm

Status:Needs review» Needs work

The last submitted patch, 1981342-10.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new23.09 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php.
[ View ]

Core is moving fast

Status:Needs review» Needs work

The last submitted patch, 1981342-12.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new24.41 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-14.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Hmm

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, 1981342-14.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new24.41 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-16.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

*sigh*

Status:Needs review» Needs work

The last submitted patch, 1981342-16.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new23.09 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php.
[ View ]

I fail so hard at creating patches

Status:Needs review» Needs work

The last submitted patch, 1981342-18.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new950 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981342-20.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Oh yes I do

Status:Needs review» Needs work

The last submitted patch, 1981342-20.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new23.09 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.php.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1981342-21.patch, failed testing.

aspilicious’s picture

Ok I give up, apparantly guys can't do 2 things at the same time... Feel free to fix the remaining failures while I'm gone...

andypost’s picture

Status:Needs work» Needs review
StatusFileSize
new23.84 KB
PASSED: [[SimpleTest]]: [MySQL] 57,804 pass(es).
[ View ]
new5.54 KB

Merged changes and pushed to sandbox
git diff 8.x core/modules/s* core/modules/u* core/modules/v* core/scripts > 1981342-25.patch

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

THANK YOU!!

alexpott’s picture

Issue tags:-Field API

#25: 1981342-25.patch queued for re-testing.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 1981342-25.patch, failed testing.

andypost’s picture

Status:Needs work» Needs review
Issue tags:+Field API

#25: 1981342-25.patch queued for re-testing.

andypost’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new23.84 KB
PASSED: [[SimpleTest]]: [MySQL] 57,864 pass(es).
[ View ]

Should be green, just merged sandbox - patch the same except a few offsets

Status:Reviewed & tested by the community» Needs work
Issue tags:-Field API

The last submitted patch, 1981342-30.patch, failed testing.

amateescu’s picture

Status:Needs work» Needs review

#30: 1981342-30.patch queued for re-testing.

Fail was coming from #1838310: Remove st(), get_t() and $t for good, should be ok now.

Status:Needs review» Needs work

The last submitted patch, 1981342-30.patch, failed testing.

pcambra’s picture

Status:Needs work» Needs review
Issue tags:+Field API

#30: 1981342-30.patch queued for re-testing.

andypost’s picture

swentel’s picture

I think we're safe tbh, we're directly working on the field, so don't see the difference, unless I'm mistaken ...

swentel’s picture

#30: 1981342-30.patch queued for re-testing.

swentel’s picture

Status:Needs review» Reviewed & tested by the community

RTBC when it comes back green.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 72bd779 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

Updated issue summary.