Part of #1953410: [Meta] Remove field_create_*(), field_update_*() and field_delete_*() in favor of just using the ConfigEntity API

git diff 8.x core/modules/s* core/modules/u* core/modules/v* core/scripts >1981342-x.patch

CommentFileSizeAuthor
#30 1981342-30.patch23.84 KBandypost
#25 interdiff.txt5.54 KBandypost
#25 1981342-25.patch23.84 KBandypost
#22 1981342-21.patch23.09 KBaspilicious
#20 1981342-20.patch950 bytesaspilicious
#18 1981342-18.patch23.09 KBaspilicious
#16 1981342-16.patch24.41 KBaspilicious
#14 1981342-14.patch24.41 KBaspilicious
#12 1981342-12.patch23.09 KBaspilicious
#10 1981342-10.patch23.09 KBaspilicious
#8 1981342-8.patch91.24 KBaspilicious
#7 1981342-7.patch18.18 KBswentel
#1 1953410-cud-1981342-1.patch18.65 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
1953410-cud-1981342-1.patch18.65 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Novice

tagged to office hours

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Closed (won't fix)

We're going todo this in one patch.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Closed (won't fix) » Needs review

So we agreed to this in chunks anyway.

swentel’s picture

swentel CreditAttribution: swentel commented
Issue tags: -Novice, -Field API

#1: 1953410-cud-1981342-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Field API

The last submitted patch, 1953410-cud-1981342-1.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
1981342-7.patch18.18 KB

rerolled

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1981342-8.patch91.24 KB

Reroll + some changes. Could fail...

Status: Needs review » Needs work

The last submitted patch, 1981342-8.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-10.patch23.09 KB

Hmm

Status: Needs review » Needs work

The last submitted patch, 1981342-10.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-12.patch23.09 KB

Core is moving fast

Status: Needs review » Needs work

The last submitted patch, 1981342-12.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-14.patch24.41 KB

Hmm

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, 1981342-14.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-16.patch24.41 KB

*sigh*

Status: Needs review » Needs work

The last submitted patch, 1981342-16.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-18.patch23.09 KB

I fail so hard at creating patches

Status: Needs review » Needs work

The last submitted patch, 1981342-18.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-20.patch950 bytes

Oh yes I do

Status: Needs review » Needs work

The last submitted patch, 1981342-20.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1981342-21.patch23.09 KB

Status: Needs review » Needs work

The last submitted patch, 1981342-21.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Ok I give up, apparantly guys can't do 2 things at the same time... Feel free to fix the remaining failures while I'm gone...

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review
FileSize
1981342-25.patch23.84 KB
interdiff.txt5.54 KB

Merged changes and pushed to sandbox
git diff 8.x core/modules/s* core/modules/u* core/modules/v* core/scripts > 1981342-25.patch

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

THANK YOU!!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue tags: -Field API

#25: 1981342-25.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1981342-25.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review
Issue tags: +Field API

#25: 1981342-25.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community
FileSize
1981342-30.patch23.84 KB

Should be green, just merged sandbox - patch the same except a few offsets

Status: Reviewed & tested by the community » Needs work
Issue tags: -Field API

The last submitted patch, 1981342-30.patch, failed testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Needs review

#30: 1981342-30.patch queued for re-testing.

Fail was coming from #1838310: Remove st(), get_t() and $t for good, should be ok now.

Status: Needs review » Needs work

The last submitted patch, 1981342-30.patch, failed testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs work » Needs review
Issue tags: +Field API

#30: 1981342-30.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Suppose we should get answer on #1950632-151: Create a FieldDefinitionInterface and use it for formatters and widgets to rtbc again

swentel’s picture

swentel CreditAttribution: swentel commented

I think we're safe tbh, we're directly working on the field, so don't see the difference, unless I'm mistaken ...

swentel’s picture

swentel CreditAttribution: swentel commented

#30: 1981342-30.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

RTBC when it comes back green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 72bd779 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.