Files: 
CommentFileSizeAuthor
#33 1981316-33.patch28.89 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 57,899 pass(es).
[ View ]
#33 interdiff.txt706 bytesswentel
#31 1981316-31.patch28.89 KBpcambra
PASSED: [[SimpleTest]]: [MySQL] 57,580 pass(es).
[ View ]
#28 interdiff.txt2.95 KBpcambra
#28 interdiff-1.txt14.36 KBpcambra
#28 1981316-28.patch28.88 KBpcambra
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981316-28.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#25 interdiff.txt13.5 KBpcambra
#25 1981316-25.patch28.66 KBpcambra
FAILED: [[SimpleTest]]: [MySQL] 55,954 pass(es), 3 fail(s), and 0 exception(s).
[ View ]
#23 1981316-23.patch27.3 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]
#21 1981316-21.patch27.27 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]
#19 1981316-19.patch27.31 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]
#17 1981316-17.patch28.1 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] 55,410 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#15 1981316-15.patch28.1 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] 55,888 pass(es), 9 fail(s), and 5 exception(s).
[ View ]
#13 1981316-13.patch28.14 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]
#13 1981316-13-interdiff.txt21.72 KBaspilicious
#10 1981316-9.patch16.35 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 56,388 pass(es).
[ View ]
#5 interdiff.txt1.07 KBandypost
#5 1953410-cud-1981316-5.patch17.7 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981316-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 interdiff.txt815 bytesandypost
#2 1953410-cud-1981316-2.patch17.5 KBandypost
FAILED: [[SimpleTest]]: [MySQL] 55,520 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#1 1953410-cud-1981316-1.patch17.49 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Comments

andypost’s picture

Status:Active» Needs review
StatusFileSize
new17.49 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
andypost’s picture

Issue tags:+Field API
StatusFileSize
new17.5 KB
FAILED: [[SimpleTest]]: [MySQL] 55,520 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
new815 bytes

Missed one place

andypost’s picture

Issue tags:+Novice

tagged for office hours review

Status:Needs review» Needs work

The last submitted patch, 1953410-cud-1981316-2.patch, failed testing.

andypost’s picture

Status:Needs work» Needs review
StatusFileSize
new17.7 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981316-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new1.07 KB

Fix broken test

swentel’s picture

Status:Needs review» Closed (won't fix)

We're going todo this in one patch.

swentel’s picture

Status:Closed (won't fix)» Needs review

So we agreed to this in chunks anyway.

swentel’s picture

Issue tags:-Novice, -Field API

#5: 1953410-cud-1981316-5.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +Field API

The last submitted patch, 1953410-cud-1981316-5.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new16.35 KB
PASSED: [[SimpleTest]]: [MySQL] 56,388 pass(es).
[ View ]

Rerolled

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Looking good

aspilicious’s picture

Status:Reviewed & tested by the community» Needs review

back to nr for now, other issue has some interesting comments

aspilicious’s picture

StatusFileSize
new21.72 KB
new28.14 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]

Some changes to make use of the objects in stead of the bc layer.

Status:Needs review» Needs work

The last submitted patch, 1981316-13.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new28.1 KB
FAILED: [[SimpleTest]]: [MySQL] 55,888 pass(es), 9 fail(s), and 5 exception(s).
[ View ]

Hand edited patches FTW

Status:Needs review» Needs work

The last submitted patch, 1981316-15.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new28.1 KB
FAILED: [[SimpleTest]]: [MySQL] 55,410 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Hmm moe like a reroll. I wonder why there are so many unrelated tests failing...

Status:Needs review» Needs work

The last submitted patch, 1981316-17.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new27.31 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]

Hopefully green. I had to manually reroll large pieces, hopefully it worked...

Status:Needs review» Needs work

The last submitted patch, 1981316-19.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new27.27 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1981316-21.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new27.3 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php.
[ View ]

:(

Status:Needs review» Needs work

The last submitted patch, 1981316-23.patch, failed testing.

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new28.66 KB
FAILED: [[SimpleTest]]: [MySQL] 55,954 pass(es), 3 fail(s), and 0 exception(s).
[ View ]
new13.5 KB

Let's see what the testbot thinks. Also attaching an interdiff, not sure what chunks of this patch have been actuallly included in the sandbox.

swentel’s picture

This is looking great too, just one remark, after that it's RTBC.

- edit - RTBC if it's green of course ;)

+++ b/core/modules/image/lib/Drupal/image/Tests/ImageFieldDefaultImagesTest.phpundefined
@@ -51,30 +51,28 @@ function testDefaultImages() {
-      'label' => $instance['label'],
-      'required' => $instance['required'],
+      'label' => $instance->id(),

Let's use $instance->label instead of ->id().

Status:Needs review» Needs work

The last submitted patch, 1981316-25.patch, failed testing.

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new28.88 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981316-28.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new14.36 KB
new2.95 KB

Moved the field name declaration upper for the link tests and fixed @swentel comment on #26

aspilicious’s picture

Looking great thnx for finishing this!

Status:Needs review» Needs work

The last submitted patch, 1981316-28.patch, failed testing.

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new28.89 KB
PASSED: [[SimpleTest]]: [MySQL] 57,580 pass(es).
[ View ]

Phew, core is moving fast, here's a confict fix on #28, no further changes.

andypost’s picture

RTBC. Only small nitpick, this should be commited to sandbox

+++ b/core/modules/image/lib/Drupal/image/Tests/ImageFieldDefaultImagesTest.phpundefined
@@ -51,30 +51,28 @@ function testDefaultImages() {
+      'label' => $instance->label,

let's use label() method to make it easy convert ot NG

swentel’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new706 bytes
new28.89 KB
PASSED: [[SimpleTest]]: [MySQL] 57,899 pass(es).
[ View ]

Indeed. Great work all!

andypost’s picture

+1 rtbc, @swentel please merge the patch to sandbox

alexpott’s picture

Issue tags:-Novice, -Field API

#33: 1981316-33.patch queued for re-testing.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 1981316-33.patch, failed testing.

andypost’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +Field API

#33: 1981316-33.patch queued for re-testing.

andypost’s picture

Status:Needs review» Reviewed & tested by the community

back to rtbc

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed a6a4adc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.