Drop procedural usage of fields in field module

We're going todo this in one patch.

So we agreed to this in chunks anyway.

#1: 1953410-cud-1981314-1.patch queued for re-testing.

rerolled - not sure if the diff was taken right as it's so big, but I assume it's ok.

You removed to much ;)

Hopefully this one will apply and come back green

Here is the patch. I don't think we should clean this one up as the others. Will be an unneeded bikeshed issue.

I hope for less than 5 fails :p

ANother try

#12: 1981314-12.patch queued for re-testing.

Working on this, I'll post a patch in a few mins.

#12 is a patch from another issue :(

Rerrolling #10 and fixing a number of docs, scopes and typos.

Also, are we keeping the field crud functions in field.crud.inc for compatibility purposes or shall we delete those as well?

After discussing with swentel on IRC, we're removing the field crud functions in this patch.

Expect this one to fail horribly, as all the dependent ones are going to still call the crud functions.

#17: 1981314-17.patch queued for re-testing.

#17: 1981314-17.patch queued for re-testing.

+++ b/core/modules/field/lib/Drupal/field/Tests/BulkDeleteTest.php
@@ -104,29 +143,38 @@ function setUp() {
+        $instance = entity_create('field_instance', array(
+          'field_name' => $field->id(),
           'entity_type' => $this->entity_type,
           'bundle' => $bundle,
-        );
-        $this->instances[] = field_create_instance($instance);
+        ))->save();

save() does not return the entity. It actually returns a constant. How is it this isn't triggering test errors?

How is it this isn't triggering test errors?

Because apparently $this->instances is not invoked from anywhere.

Re-roll removing the instances array as it's unused.

Woot! Committed to 8.x. Thanks.