On those operation, the entityform has no ID, so the link to the submitted entity cannot be created. So it should not be shown in the template file.

CommentFileSizeAuthor
#1 entityform-submitted-data-theeme-not-compatible-when-entity-not-stored-1981094-1.patch1.52 KBB-Prod
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

B-Prod’s picture

B-Prod CreditAttribution: B-Prod commented
Status: Active » Needs review
FileSize
entityform-submitted-data-theeme-not-compatible-when-entity-not-stored-1981094-1.patch1.52 KB

Fixed by this patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented
Issue summary: View changes
Status: Needs review » Needs work 
+++ b/entityform-submittd-data.tpl.php
@@ -28,4 +28,6 @@
+<?php if ($url): ?>
+  <?php print t('The results of this submission may be viewed at: !url', array('!url' => $url)); ?>
+<?php endif; ?>

I don't like hard coding this message here.

B-Prod’s picture

B-Prod CreditAttribution: B-Prod commented
Status: Needs work » Needs review

This is not the point that is discussed here. The message is already part of the template, so if it needs to be handled differently, this should be done through another issue.

The point here is related to a bug and not this coding design detail. Moreover I do not change the way it is currently done: the t() function already stands in the template ;-)

  • tedbow committed 8bbd4c3 on 7.x-2.x authored by B-Prod 
    Issue #1981094 by B-Prod: Fixed The submitted data theme is not...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented
Status: Needs review » Fixed

@B-Prod thanks for the patch! commited

  • tedbow committed 8bbd4c3 on 7.x-2-metatags-2344293 authored by B-Prod 
    Issue #1981094 by B-Prod: Fixed The submitted data theme is not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.