I found a few grammatical errors in the text there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | fix-grammatical-errors-1978074-3.patch | 2.75 KB | nagy.balint |
| #1 | fix-grammatical-errors-1978074-1.patch | 2.74 KB | nagy.balint |
I found a few grammatical errors in the text there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | fix-grammatical-errors-1978074-3.patch | 2.75 KB | nagy.balint |
| #1 | fix-grammatical-errors-1978074-1.patch | 2.74 KB | nagy.balint |
Comments
Comment #1
nagy.balint commentedpatch attached.
Comment #2
DeFr commentedI'm not sure about the "It is not really a really hook. Only one modules is invoke" part of the change. The sentence obviously needs to be tweaked, but the "only one module invokes it" seems to be a bit misleading. Maybe "This will only be invoked for the module providing the {player,atom,…}" would be clearer. ?
Comment #3
nagy.balint commentedYes it seems some of those strings are quite old.
For hook_scald_player_settings_form it seems it is invoked on the settings edit form of the player for a given provider. However i could not find its menu item on the UI, maybe i just missed it.
For hook_scald_register_atom, it is indeed misleading. At the moment the image provider and the scald_file provider uses it to sync the file field's fid back to the base id. It is invoked on atom creation for the module that provided the atom type.
For hook_scald_render, as far as i see this is used for providing markup for contexts. Both in scald (library and such) and in other modules that provide contexts.
Updated patch attached.
Comment #4
nagy.balint commentedComment #5
jcisio commentedThanks. I also fixed some indentation problem and a few other bugs then committed.