Hi,

I'm using twitter's 7.x-6.0-alpha1+3-dev version.

I've added a field of type "twitter" and widget as "Post to Twitter". After adding this field, the node add form started showing error "Uncaught RangeError: Maximum call stack size exceeded" in Chrome developer console. The alert/error was also shown when I was clicking on "add another item" button on form.

After some debugging I've found that the error is caused because of token implementation for twitter field in twitter_post.field.inc file. I've applied the attached patch to module, then the error stopped coming but the tokens are not coming. I don't know what am I missing.

Yogesh

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Version: 7.x-6.0-alpha1 » 7.x-6.x-dev
Issue summary: View changes
Status: Active » Needs review

When you upload a patch please change the issue status to "Needs review", that tells others that there's a patch to review :) Thanks!

DamienMcKenna’s picture

Status: Needs review » Needs work

Triggering the testbot.

DamienMcKenna’s picture

Status: Needs work » Needs review

Triggering the testbot.

yogeshchaugule8’s picture

patch passed testing successfully, should we be asking module maintainer for including patch in module?

DamienMcKenna’s picture

I'll review it soon - there are a *lot* of patches to review, so it'll take me a little bit to get through them all.

yogeshchaugule8’s picture

Thank you.

DamienMcKenna’s picture

FileSize
476 bytes

The original patch disables the token browser. How about this instead - it loads the token browser in a popup? I haven't tested this myself, but it should work.

DamienMcKenna’s picture

This only affects the 7.x-6.x branch, the other branches don't use the token browser.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.