Hi,
I'm using twitter's 7.x-6.0-alpha1+3-dev version.
I've added a field of type "twitter" and widget as "Post to Twitter". After adding this field, the node add form started showing error "Uncaught RangeError: Maximum call stack size exceeded" in Chrome developer console. The alert/error was also shown when I was clicking on "add another item" button on form.
After some debugging I've found that the error is caused because of token implementation for twitter field in twitter_post.field.inc file. I've applied the attached patch to module, then the error stopped coming but the tokens are not coming. I don't know what am I missing.
Yogesh
Comment | File | Size | Author |
---|---|---|---|
#8 | twitter-n1971744-8.patch | 476 bytes | DamienMcKenna |
Comments
Comment #1
DamienMcKennaWhen you upload a patch please change the issue status to "Needs review", that tells others that there's a patch to review :) Thanks!
Comment #2
DamienMcKennaTriggering the testbot.
Comment #3
DamienMcKennaTriggering the testbot.
Comment #5
yogeshchaugule8 CreditAttribution: yogeshchaugule8 commentedpatch passed testing successfully, should we be asking module maintainer for including patch in module?
Comment #6
DamienMcKennaI'll review it soon - there are a *lot* of patches to review, so it'll take me a little bit to get through them all.
Comment #7
yogeshchaugule8 CreditAttribution: yogeshchaugule8 commentedThank you.
Comment #8
DamienMcKennaThe original patch disables the token browser. How about this instead - it loads the token browser in a popup? I haven't tested this myself, but it should work.
Comment #9
DamienMcKennaThis only affects the 7.x-6.x branch, the other branches don't use the token browser.
Comment #10
DamienMcKennaCommitted.