It would be great to have compatibility with the effects provided by the Manual Crop module (http://drupal.org/project/manual-crop).

Comments

dbazuin’s picture

I guess support voor crop modules like manual crop is essential voor this module.
Setting the jpeg quality to 25 does not work if cropped images are not retinifyed.

Regards
Dirk

ptmkenny’s picture

Issue summary: View changes

Has anyone got this working with Manual Crop in the past two years? If not, what are the issues that need to be solved to make the two modules compatible?

jnettik’s picture

I would check out the Picture module if you're looking to support high resolutions and use Manual Crop. It uses the picture element in HTML, which is the new standard for supporting high resolution images (among other things).

gaëlg’s picture

Status: Active » Needs work

Here's how I got it for manual scale and crop:

function retina_images_image_effect_info_alter(&$effects) {
  if (module_exists('manualcrop')) {
    // Manual scale and crop effect
    $effects['manualcrop_crop_and_scale']['form callback'] = 'retina_images_manualcrop_crop_and_scale_form';
    $effects['manualcrop_crop_and_scale']['effect callback'] = 'retina_images_manualcrop_crop_and_scale_effect';
    $effects['manualcrop_crop_and_scale']['summary theme'] = 'retina_images_manualcrop_crop_and_scale_summary';
    $effects['manualcrop_crop_and_scale']['dimensions callback'] = 'image_resize_dimensions';
  }
}

function retina_images_theme() {
  return array(
    'retina_images_manualcrop_crop_and_scale_summary' => array('variables' => array('data' => NULL), ),
  );
}

function retina_images_manualcrop_crop_and_scale_form($data) {
  $form = manualcrop_crop_and_scale_form($data);
  retina_images_form_helper($form, $data);
  return $form;
}

function retina_images_manualcrop_crop_and_scale_effect(&$image, $data) {
  retina_images_multiply_data_dimensions($data);
  return manualcrop_crop_and_scale_effect($image, $data);
}

function theme_retina_images_manualcrop_crop_and_scale_summary($variables) {
  $data = $variables["data"];
  return theme('manualcrop_crop_and_scale_summary', $variables) . ' ' . ($data['retinafy'] ? '(' . t('retinafied') . ')' : '');
}

I did not provide a patch as this would need to be done for every manual crop effect, not scale and crop only.

lpalgarvio’s picture

astonvictor’s picture

Status: Needs work » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.