Prompted by this conversion:

This is in an attempt to allow those output tags in

to be rendered as twig files. The issue above is for aggregator module but this would be a template needed by both node_feed(), which is used by taxonomy and the aggregator module.

Proposed resolution

Create a new theme function for these format functions, and use the theme for theme_aggregator_page_rss() and node_feed()

API changes

Removes these functions and replaces them with Twig templates:


#401584: Convert format_rss_items(), format_rss_channel() and format_xml_elements() to use SimpleXML
#1896060: aggregator.module - Convert PHPTemplate templates to Twig


joelpittet’s picture

Issue tags: +Twig


shanethehat’s picture

Assigned: Unassigned » shanethehat

I'd like to have a go at this, but if I'm taking too long anyone feel free to step in.

joelpittet’s picture

@shanethehat great, thank you! It's not very similar to the other conversions because we haven't really touched format_ functions. Though if the *new* theme template can handle it it may also allow consolidation of Views RSS as well #1843758: Convert views/templates/views-view-row-rss.tpl.php to twig

Cottser’s picture

At this time this issue could almost be postponed IMO, it's more of a long-term thing.

@shanethehat - Please join us in #drupal-twig if you'd like to help out with the Twig conversion effort in general. Thanks! :)

joelpittet’s picture

Assigned: shanethehat » Unassigned
Issue summary: View changes
Status: Active » Postponed

I agree, postponing. The wash may iron this.

mgifford’s picture

#1843758: Convert views/templates/views-view-row-rss.tpl.php to twig got into Core. Has this indeed ironed itself out?

Would have been way better to have been able to just ask this in person in SF. :)

mikeker’s picture

mgifford’s picture

Status: Postponed » Active
Cottser’s picture

Status: Active » Closed (cannot reproduce)

I think we're good because of #2251111: Remove format_rss_item() and format_rss_channel(), thanks for the bump @mgifford :)