jQuery UI 1.10 update broke Create.js, and thus in-place editing

I get a JS error when quick editing a node (simple Article from the front page view listing)

Going through the stack, we're finding the predicate element (the body field) correctly.

The call to this function

this._params(predicate)

seems to be failing. It's in file create-editonly.js around line 600.

Hmmm, and now it appears to be working. Maybe I just had a cached version of the JS file. Sigh.

I'm getting an AJAX error when attempting to save a body field from Quick edit.

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /index.php/edit/form/node/1/body/und/full
StatusText: OK
ResponseText: Recoverable fatal error: Argument 1 passed to Drupal\file\FileUsage\DatabaseFileUsageBackend::add() must be an instance of Drupal\file\Plugin\Core\Entity\File, boolean given, called in /Users/jbeach/code/drupal/core/d8/core/modules/file/file.field.inc on line 267 and defined in Drupal\file\FileUsage\DatabaseFileUsageBackend->add() (line 51 of /Users/jbeach/code/drupal/core/d8/core/modules/file/lib/Drupal/file/FileUsage/DatabaseFileUsageBackend.php).

So, Wim and I verified that the AJAX error I'm seeing is not present on simplytest.me. I'm investigating my local setup further, but it seems that the errors I'm getting have to do with my local setup and not this patch.

Nah nah nah, not so fast. I looked into my local error further and found that when the language module is enabled, I get the error in #9 when saving an in-place edited field.

The trigger for this error may be something we stumbled upon with this patch instead of introduced. The ultimate cause is still unknown. From my attempts to debug, I can't get a breakpoint to catch in the functions mentioned in the error. The error feels like a red herring.

Agreed with #14. I'm putting together the findings from my debugging of the AJAX issue and opening a new ticket. I'll link it here. What this patch here does is expose what has been dormant in the field code before now.

Here's the related bug #1963334: Edit incompatible with language module (?): AJAX save of an Article node results in an error related to the image field.

Hm. That's sub-optimal, but it'd definitely be good to get this working at all again.

Committed and pushed to 8.x. Thanks.

Incidentally, this makes me cranky:

+++ b/core/misc/create/create-editonly.jsundefined
@@ -964,7 +964,7 @@
-  jQuery.widget('Create.halloWidget', jQuery.Create.editWidget, {
+  jQuery.widget('Midgard.halloWidget', jQuery.Midgard.editWidget, {

And especially this:

+++ b/core/modules/edit/js/createjs/editingWidgets/drupalcontenteditablewidget.jsundefined
@@ -8,7 +8,7 @@
-  jQuery.widget('DrupalEditEditor.direct', jQuery.Create.editWidget, {
+  jQuery.widget('Midgard.direct', jQuery.Midgard.editWidget, {

Midgard is a different CMS project entirely, it doesn't really make sense to pull their namespace into our project. However, it looks like according to https://github.com/bergie/create/issues/173, having that string hard-coded to "Midgard" is this is an upstream issue, hopefully will be resolved with a subsequent Create.js update.