Closed (won't fix)
Project:
Edit
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
5 Apr 2013 at 11:08 UTC
Updated:
28 Nov 2013 at 15:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
wim leers(Reported in D7 Spark: #1961746: In-place editing not working because alpha 8 uses jQuery UI 1.10.)
Comment #2
wim leersAFAICT it is impossible to be compatible with both jQuery UI 1.8 and 1.10 without hacks. So, the solution to this issue:
Comment #3
wim leersIn the meantime, here's a 1:1 port of #1960612-3: jQuery UI 1.10 update broke Create.js, and thus in-place editing to D7. If the OP were to apply this patch, then all should be well.
Comment #4
kriboogh commentedI can confirm the patch in #3 works
Comment #5
wim leersThanks for confirmation :)
Comment #6
OnkelTem commentedThe patch from #3 does't apply on the latest git vesion of Edit (commit 291fea80598adfa27ea85074e73205e869052dcd)
Comment #7
OnkelTem commentedHere is the updated version of the patch from #3.
I confirm it fixes jQuery UI 1.10.x issues but breaks old jQuery UI :)
So it's need to be updated so that both old and new jQuery UIs get working.
Comment #8
OnkelTem commentedNot everything goes smooth though.
I can successfuly edit and save text fields, but body field isn't saved.
When I click to edit a body field, error message arises (sorry for missed formatting):
Screenshot:

Comment #9
wim leersYes, the patch to update Create.js indeed breaks old jQuery UI, which is why I haven't committed this yet :)
For a solution to that, see https://github.com/bergie/create/issues/173#issuecomment-15951454
I'm currently waiting for feedback to see how the Create.js maintainer wants to see that implemented: https://github.com/bergie/create/issues/173#issuecomment-16567518
Comment #10
OnkelTem commentedI finally managed to get editing working, with a proviso though.
1) "has no method 'inline'" message was related to CKEditor. After I upgraded the library to 4.1, editing started working.
2) However, I ran into another problem. If there is only one textarea field on a page for which ckeditor is used, editing doesn't work and error message arises:
which actually occurs in the line of
drupalckeditorwidget.js:jQuery.widget('Midgard.ckeditor', jQuery.Midgard.direct, {but
jQuery.Midgard.directis defined indrupalcontenteditablewidget.jswhich is not loaded. PerhapsjQuery.Midgard.editWidgetshould be used here. Patch is provided.Comment #11
OnkelTem commentedI occasionally changed to bug report. Changing it back.
Comment #12
wim leersWhat you reported in #10 is already fixed in alpha 11, in this commit: http://drupalcode.org/project/edit.git/commit/291fea8 :)
Comment #13
OnkelTem commentedI made this fix for your patch, not for the master branch.
Does this mean the patch from #3 is not required anymore?
Comment #14
Renee S commentedA head's up, it looks like the maintainer of Create.js has pushed some changes to make it compatible with both 1.10 and < 1.10.
Comment #15
Peribanu commentedCan anyone confirm what the current fix is for 7.x-1.x-dev? The download being offered from the Spark project page dated 10th May is still broken.
Comment #16
wim leersThat was wrong for a while now.
#15: sorry for our unresponsiveness; we're working very hard to get everything as stable as possible in D8 before July 1. Expect massive progress and super smooth experience shortly after July 1!
Comment #17
wim leersThat was wrong for a while now.
#15: sorry for our unresponsiveness; we're working very hard to get everything as stable as possible in D8 before July 1. Expect massive progress and super smooth experience shortly after July 1!
Comment #18
wim leersThat was wrong for a while now.
#15: sorry for our unresponsiveness; we're working very hard to get everything as stable as possible in D8 before July 1. Expect massive progress and super smooth experience shortly after July 1!
Comment #19
wim leersThat was wrong for a while now.
#15: sorry for our unresponsiveness; we're working very hard to get everything as stable as possible in D8 before July 1. Expect massive progress and super smooth experience shortly after July 1!
Comment #20
pjezek commentedHi,
I just discovered that this affects me as well.
For now I use this workaround with 7.x-1.0-alpha9+0-dev:
Settings jQuery to use 1.5 as default jQuery version and 1.7 in Admin. (see screenshot)
Comment #20.0
pjezek commentedUpdated issue summary.
Comment #21
socialnicheguru commented#10 patch, https://drupal.org/files/create_js_jquery_ui_1_10-1962274-10.patch, worked for me on Drupal 7.
I have jquery_update 1.7, jquery 1.10. I need 1.7 because of other modules
Comment #22
wim leersI'm currently working on backporting Drupal 8's implementation of in-place editing. That implementation no longer depends on Create.js. Consequently, the incompatibility with jQuery 1.10 will be fixed as well.
(Drupal 8 uses jQuery 2.0.3, so expect compatibility with that version as well.)