IGNORE: Patch testing issue ✌✌

That's not what I had in mind.

Trying to find out why this fails randomly...

Forgot to add a file.

lets see how badly this fails

previous patch stuck..needs cancelling..here is a new one

and with updated vendors...

nope..

+++ b/core/lib/Drupal/Core/EventSubscriber/SessionListener.phpundefined
@@ -0,0 +1,98 @@
+      // @todo Restore this once all page callbacks are converted to new routing
+      // @see drupal_session_initialize().

Restore what? I don't see anything being commented out here.

+++ b/core/lib/Drupal/Core/Session/Session.phpundefined
@@ -0,0 +1,204 @@
+    $cookies = array();

All in all I really like how this code has evolved. Great work.
$cookies should be initialized with the object not scoped as a local variable.

+++ b/core/lib/Drupal/Core/Session/Session.phpundefined
@@ -0,0 +1,204 @@
+   * dangerous operations, such as manipulating the global $user object.

Do we intend to have a "global" $user object by the end of D8?

+++ b/core/lib/Drupal/Core/Session/Storage/Proxy/CookieProxy.phpundefined
@@ -0,0 +1,399 @@
+   * @todo Fix one http://drupal.org/node/1825332 is in.

s/one/once

+++ b/core/lib/Drupal/Core/Session/Storage/Proxy/CookieProxy.phpundefined
@@ -0,0 +1,399 @@
+   * @todo Fill me.

Do @todo's like this one mean that you're asking for documentation of methods like this.

aaaargh.

Testbot isn't nice to me.

#186: 1958050_185.patch queued for re-testing.

Trying some more, not sure if only the patch with all tests is randomly failing.