The default modal size is okey for the base providers, but might not be for other providers and for the plupload integration.
The size should be possible to set in the dnd settings.

CommentFileSizeAuthor
#6 set-ctools-modal-size-1957512-6.patch3.04 KBnagy.balint
#2 set-ctools-modal-size-1957512-2.patch2.14 KBhaza
#1 set-ctools-modal-size-1957512-1.patch1.69 KBnagy.balint

Comments

nagy.balint’s picture

nagy.balint commented
StatusFileSize
new set-ctools-modal-size-1957512-1.patch1.69 KB

Patch attached, that adds two textfields to the dnd settings to set the ctools modal window's size.

haza’s picture

haza
Primary language French
commented
StatusFileSize
new set-ctools-modal-size-1957512-2.patch2.14 KB

We should validate for numeric only values there.

Patch that add that attached.

jcisio’s picture

jcisio commented
Status: Needs review » Needs work

CTools modal can take values in both 'px' and '%' units.

haza’s picture

haza
Primary language French
commented 
+    '#description' => t('The height of the modal window opened from the library in pixels.'),

Well, we tell the user we want pixel.

Should we change that to accept % also, and thus change the validate function or we do we only want to allow pixels ?

jcisio’s picture

jcisio commented

I think we should change the validate function to accept both % and pixel (and check both width/have use the same unit). In case the size is in '%', we need to change type => 'fixed' to type => 'scale', too.

nagy.balint’s picture

nagy.balint commented
Status: Needs work » Needs review
StatusFileSize
new set-ctools-modal-size-1957512-6.patch3.04 KB

I extended the patch.

Now if number is between 0 and 1 (like 0.5, 0.7 etc) then it will assume that its a percentage value (as any pixel value below like 200 will not work anyways), and if the number is above 1 then it assumes it is a pixel value.

It will also make sure negative numbers cannot be entered. Because of the percentage value, i convert the input to (float), so it is good for both cases.

jcisio’s picture

jcisio commented
Status: Needs review » Fixed

Thanks. Committed #6 with a spelling fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.