Setting the size of the ctools modal window [#1957512]

The default modal size is okey for the base providers, but might not be for other providers and for the plupload integration.
The size should be possible to set in the dnd settings.

Comment	File	Size	Author
#6	set-ctools-modal-size-1957512-6.patch	3.04 KB	nagy.balint
#6
#2	set-ctools-modal-size-1957512-2.patch	2.14 KB	Haza
#2
#1	set-ctools-modal-size-1957512-1.patch	1.69 KB	nagy.balint
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

nagy.balint CreditAttribution: nagy.balint commented 31 March 2013 at 19:57

File	Size
set-ctools-modal-size-1957512-1.patch	1.69 KB

Patch attached, that adds two textfields to the dnd settings to set the ctools modal window's size.

Comment #2

Haza

French

CreditAttribution: Haza commented 4 April 2013 at 08:40

File	Size
set-ctools-modal-size-1957512-2.patch	2.14 KB

We should validate for numeric only values there.

Patch that add that attached.

Comment #3

jcisio CreditAttribution: jcisio commented 4 April 2013 at 08:42

Status:

Needs review

» Needs work

CTools modal can take values in both 'px' and '%' units.

Comment #4

Haza

French

CreditAttribution: Haza commented 4 April 2013 at 09:24

+    '#description' => t('The height of the modal window opened from the library in pixels.'),

Well, we tell the user we want pixel.

Should we change that to accept % also, and thus change the validate function or we do we only want to allow pixels ?

Comment #5

jcisio CreditAttribution: jcisio commented 4 April 2013 at 10:00

I think we should change the validate function to accept both % and pixel (and check both width/have use the same unit). In case the size is in '%', we need to change type => 'fixed' to type => 'scale', too.

Comment #6

nagy.balint CreditAttribution: nagy.balint commented 27 April 2013 at 12:43

Status:

Needs work

» Needs review

File	Size
set-ctools-modal-size-1957512-6.patch	3.04 KB

I extended the patch.

Now if number is between 0 and 1 (like 0.5, 0.7 etc) then it will assume that its a percentage value (as any pixel value below like 200 will not work anyways), and if the number is above 1 then it assumes it is a pixel value.

It will also make sure negative numbers cannot be entered. Because of the percentage value, i convert the input to (float), so it is good for both cases.