Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Mar 2013 at 09:39 UTC
Updated:
23 Apr 2013 at 12:26 UTC
Jump to comment: Most recent file
Comments
Comment #1
damienmckennaHow would this look? Given the module's internal name is "metatag" it makes sense that the module's proper name be "Metatag".
Comment #2
damienmckennaComment #3
dave reidHrm, I don't think it makes sense to make the internal name match exactly the the module name. 'Meta tag' is the proper term and I don't think it should be changed.
Comment #4
klonosWell, I personally don't have any preference - I was merely pointing the fact that the project needs to "comply" with d.o standards set. At the end I guess it's up to you (since you are the maintainer).
PS: whatever you choose to go with, remember to also change the project title here in d.o too ;)
Comment #5
damienmckennaThe module name is a little confusing, e.g. the first paragraph of http://buildamodule.com/video/advanced-site-building-in-drupal-7-how-to-...
Comment #6
damienmckennaCurrent status:
I recommend we rename the module's full name to "Metatag", thus resolving the two reasons for confusion, and be done with it.
Comment #7
damienmckennaI think we'd get by using "Metatag" for the project name instead of the arguably more accurate "Meta tags" because we're using it as a proper noun, so we can name it whatever we want. Also, it's too late to rename the short name to "meta_tag". And I won't even mention how the hooks use the string "metatags" rather than "metatag" or "meta_tags" (oh wait, I did).
Comment #8
klonos:D
I'm afraid I've opened a whole bigger can of worms than I thought when I filed this issue :/
Comment #9
dave reidHah, which hooks should be fixed?
Comment #10
damienmckenna@Dave: Correction, there's only one hook with the incorrect string: hook_metatag_metatags_view_alter. However, there are fourteen internal functions use that name, but fixing that won't resolve the confusion people have over the project name.
Comment #11
damienmckennaRerolled. I really want to include this in the next release.
Comment #12
damienmckennaThis adds one or two additional changes of "Meta tags" to just say "Metatag".
Comment #13
damienmckennaI've committed this as I really do think this will help simplify the site builder's user experience.
Comment #14
klonosDo not forget the project name here on d.o too.
Comment #15
damienmckenna@klonos: I'm going to do that as soon a I release the next beta.
Comment #16
damienmckennaNow that v7.x-1.0-beta7 is out, I'm closing this in the interest of keeping the issue queue clean.
Comment #17
klonosThanx!