Usability: if a user has just failed a login, default their username on password reset

Patch applied, works good.
Better add Usability tag to it, and talk to guys at #drupal-usability on IRC, to get your patch applied.
Thanks.

Sounds good, lets get this in!

I think we can add a test for this?

For the default value. Thanks! :)

Changed the patch file name.

Changed patch attached.

Since this was RTBCed by the security team lead, I assume this is not a problem, but:

+++ b/core/modules/user/user.pages.incundefined
@@ -38,6 +38,9 @@ function user_pass() {
+  else {
+    $form['name']['#default_value'] = isset($_GET['name']) ? $_GET['name'] : '';
+  }

Is that cool? Don't we need check_plain() at least?

Also, (in D8 at least, if not also D7) referencing $GET directly is a no-no. I'm not sure what the Symfonic equivalent of it is anymore... maybe Drupal::request()->getSomething?

Oh, that said, this is an awesome improvement! :)

That's a nice improvement!

+++ b/core/modules/user/lib/Drupal/user/Tests/UserPasswordResetTest.phpundefined
@@ -108,4 +108,21 @@ public function getResetURL() {
+    $this->assertFieldByName('name',$edit['name'],'User name found.');

Missing spaces after the ","

+++ b/core/modules/user/lib/Drupal/user/Tests/UserPasswordResetTest.phpundefined
@@ -108,4 +108,21 @@ public function getResetURL() {
+    $edit = array(
+      'name' => $this->randomName(),
+      'pass' => $this->randomName(),
+      );

indent is off

+++ b/core/modules/user/user.pages.incundefined
@@ -38,6 +38,9 @@ function user_pass() {
+    $form['name']['#default_value'] = isset($_GET['name']) ? $_GET['name'] : '';

should be
$form['name']['#default_value'] = Drupal::request()->query->get('name', '');

No need for the ternary:) you can pass the default value..if NULL is appropriate here, you can omit it

+++ b/core/modules/user/user.pages.incundefined
@@ -38,6 +38,9 @@ function user_pass() {
+    $form['name']['#default_value'] = Drupal::Request()->get('name', '');

Doesnt request()->query->get() work?
Right from the link you posted:
http://api.symfony.com/2.0/Symfony/Component/HttpFoundation/Request.html...

Order of precedence: GET, PATH, POST, COOKIE
Avoid using this method in controllers:
* slow
* prefer to get from a "named" source

The query property holds $_GET:)

looks good to go:)

+++ b/core/modules/user/user.pages.incundefined
@@ -38,6 +38,9 @@ function user_pass() {
+  else {
+    $form['name']['#default_value'] = Drupal::Request()->query->get('foo');
+  }

Erm. :) I think 'name', not 'foo' :)

D7?

'n' and 'd' are far away from each other. It must have been the keyboard demon ;)

Thanx Greg!

Committed b8abe39 and pushed to 8.x. Thanks!

#39: 1952196_easier_password_recovery_d7-no-not-test.patch queued for re-testing.

simplytest.me manual tested and it is green ;)

Nice. Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/1b0d6d2

Thanx! ;)