Patch coming shortly

CommentFileSizeAuthor
#6 z-index-of-modal-popups-below-jqueryui-modals-1947404-3.patch776 bytesrobertnorrie
#2 z-index-of-modal-popups-below-jqueryui-modals-1947404-2.patch725 bytesrealityloop
#1 z-index-of-modal-popups-below-jqueryui-modals-1947404-1.patch726 bytesrealityloop
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

realityloop’s picture

realityloop
he/him
CreditAttribution: realityloop commented
Status: Active » Needs review
FileSize
z-index-of-modal-popups-below-jqueryui-modals-1947404-1.patch726 bytes
realityloop’s picture

realityloop
he/him
CreditAttribution: realityloop commented
FileSize
z-index-of-modal-popups-below-jqueryui-modals-1947404-2.patch725 bytes

reduced from 10000001 to 1000001

muhleder’s picture

muhleder CreditAttribution: muhleder commented

Why not put the z-index and position setting into css? 

#modalContent {
  z-index: 1001;
  position: absolute;
}

Plenty of themes use z-indexes higher than 1001 and having these styles applied inline prevents us from overriding it to fix the modal to work with our themes.

muhleder’s picture

muhleder CreditAttribution: muhleder commented

Ok, so it is possible to override in css. Still don't think it should be inline.

#modalContent[style] {
  z-index: 9000 !important;
}

DamienMcKenna queued 2: z-index-of-modal-popups-below-jqueryui-modals-1947404-2.patch for re-testing.

robertnorrie’s picture

robertnorrie CreditAttribution: robertnorrie commented
Issue summary: View changes
FileSize
z-index-of-modal-popups-below-jqueryui-modals-1947404-3.patch776 bytes

Attempted to apply this patch against ctools 7.x-1.11 and the patch was out of date. Uploading a new version of the patch.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Needs work

The 2 year old re-rolled patch in #6 to modal.js applied cleanly to the latest ctools 7.x-1.x-dev, but the comments in #3 and #4 still need to be addressed.