Closed (duplicate)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
15 Mar 2013 at 11:23 UTC
Updated:
22 Jan 2014 at 20:14 UTC
Jump to comment: Most recent
Comments
Comment #1
spleshkaIt seems to me that this bug is critical. Any patch won't pass tests. Patch from #1923242: Syntax error in ctools_plugin_example should be applied ASAP.
Comment #2
andypostThere's a lot of sandboxes around with patch-sets against ctools. Not sure it's possible to bring sanity in current codebase...
+1 to @podarok as co-maintainer
Also I'd like to take a part in ctools code-sprint :) a-la views-bug-squad
Comment #3
podarok#2 no problem with code sprint
Comment #4
merlinofchaos commentedI absolutely welcome CTools co-maintainers.
Since I don't particularly recognize podarok by name, but I do see a significant commit history, I'd like to go with a trial period. You don't need commit access to become highly involved with a project, and I'm going to need to some vetting to make sure that you're able to do things in the ways that I consider best and up to the standards of ctools. Which may not be as high as the standards of core, as there simply has never been the rigorous review that core has. Nonetheless, I consider ctools a higher quality piece of code, despite its warts, than a lot of other code.
1) Help people who file support requests.
2) Help identify bugs.
3) Help with the overgrown needs review queue.
4) I will put a higher priority on RTBC issues that you have marked RTBC.
I recently spent a significant chunk of time trying to reduce the needs review queue, and it's long and thorny and it has lots of stuff in it. Some of them are easy, some of them are very much not so easy. I have to imagine any serious effort at co-maintainership is going to come with a LOT of questions about my intentions and where I think something should go.
I'd also be totally willing to start work on peeling some things out of CTools and putting them in their own modules. stylizer, for example, is kind of rotting because it's now an afterthought. It was a really fun exercise while I was writing it, but the kind of effort that's going to be required to make it more than a cute toy is well beyond what I want to give it. Potentially page_manager can become its own thing, though it's got a pretty awful hard dependency on CTools in includes/context-task-handler.inc, so pulling that out would be a pretty major undertaking.
In any case, once you've gone through all this and I feel comfortable working with you, we can talk about giving you actual maintainer access. I hope you understand my reasoning.
Comment #5
podarokYup!
Of cause, I understand
It`s a true!
Comment #6
podarok@merlinofchaos - good to get access for issue queue at project maintainers tab whith give me possibility to assign issue to me or You for review
Comment #7
tim.plunkettI checked the maintainers list, and you have "Maintain Issues" perm. Proving it by assigning to you :)
Comment #8
podarok#2001370-5: Modal dialog invokes Drupal.attachBehaviors() with wrong params first for commit
#2026655-5: Fatal error if node revision argument is used yet one critical
#1157526-45: Error on upgrade 6x to 7x: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'hoslot5_ghhoa.profile_field' and major bug rtbc
#1964434-14: Token context: tokens with deep more then 1 don't work +1 RTBC
#1168272-54: Drupal blocks are shown untranslated
#1482968-23: Open modal on form submission is broken
Comment #8.0
podarokUpdated issue summary.
Comment #9
japerryMarking duplicate because this is basically looking to fix the bugs also in #2129033: [Meta] CTools 7.x-1.4 release