This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes). Check meta issue for Steps to reproduce and Coding standards

Files need to be fixed
forum.settings.yml

Files fixed already

Remaining tasks

Files: 
CommentFileSizeAuthor
#9 1942130-filter-config-format-9.patch355 bytesxtfer
PASSED: [[SimpleTest]]: [MySQL] 57,905 pass(es). View
#1 1942130-filter-config-format-1.patch357 bytessandipmkhairnar
PASSED: [[SimpleTest]]: [MySQL] 57,782 pass(es). View

Comments

sandipmkhairnar’s picture

Status: Active » Needs review
FileSize
357 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,782 pass(es). View

Mapped forum module to active config file.

vijaycs85’s picture

Component: filter.module » forum.module

Not sure whether it is changed in default or setting by default. Will need more review.

vijaycs85’s picture

Cottser’s picture

Status: Needs review » Needs work

The last submitted patch, 1942130-filter-config-format-1.patch, failed testing.

Cottser’s picture

Status: Needs work » Needs review
Issue tags: +Configuration system, +Config novice
vijaycs85’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/forum/config/forum.settings.ymlundefined
@@ -8,4 +8,4 @@ topics:
+vocabulary: 'forums'

really, really minor nit but there should not be single quotes around 'forums' to match the active config format after enabling the forum module.

xtfer’s picture

Status: Needs work » Needs review
FileSize
355 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,905 pass(es). View

Updated patch based on #8.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

thanks

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 67a8014 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.