Commerce Payseal ICICI

manual review:

1. commerce_icici.module: "global $base_url;": never used out of the function context?
2. commerce_icici_commerce_payment_method_info(): this is a hook implementation and should be documented as such, see http://drupal.org/node/1354#hookimpl . Possibly elsewhere, too?
3. commerce_icici_payment_redirect_form_validate(): do not concatenate dynamic variables into the message, use placeholders with t() instead. And don't pass dynamic variables to t() where possible as that cannot be found by translation extraction tools. Always pass string literals.
4. "t('Payment received at') . ' ' . date("d-m-Y H:i:s", REQUEST_TIME);": same here: use placeholders with t() instead.
5. commerce_icici_payment_redirect_form_validate(): a lot of variables are never used like $cv_resp_code, why do you need them?
6. commerce_icici_payment_redirect_form(): this is a form handling function and should be documented as such, see http://drupal.org/node/1354#forms

Although you should definitively fix those issues they are not major application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to mlncn as he might have time to finally approve this.

correcting icicibank link

Thank you so much klausi for reviewing the project.

we have resolved the pointed issues.

Added project review links.
Adding PAReview: review bonus tag.

Adding PAReview: review bonus tag.

No objections for more than a week, so ...

Thanks for your contribution, chintan.vyas!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.