After installing drupal (latest head) I disabled the overlay module and I noticed that primary tabs stopped working!

My screen reader recognizes the title "Primary tabs" and the tabs as plain text, so I cannot use them at all.

I don't know if this is a bare accessibility issue or primary tabs are broken on Mac OS X (don't know for other OS) even for sighted users.

When the overlay module is enabled primary tabs work properly.

CommentFileSizeAuthor
#8 fix_primary_tabs.patch442 bytesfalcon03

Comments

falcon03’s picture

falcon03 commented
Issue tags: +JavaScript, +Usability, +Accessibility

tagging

andrewmacpherson’s picture

andrewmacpherson commented

I don't currently have access to a Mac, so wasn't able to test this on OS X.

I tested with the following set-ups, and didn't encounter a problem:

  • Windows 7, Firefox 13, NVDA 2011.3
  • Windows 7, Chrome 23, ChromeVox 1.25

Primary tabs were announced as links within list items, and were operable (both with and without the overlay).

Anyone else able to confirm this on OS X?

danielnolde’s picture

danielnolde commented

I can confirm #2 that primary- as well as sub-tabs are working as expected in graphical browsers Chrome 25, Safari 6.0.1 and Firefox 15.0.1 under Mac OS X 10.8.2 (tested on admin/content/comment logged in as admin).

danielnolde’s picture

danielnolde commented

I can confirm #2 that primary- as well as sub-tabs are working as expected in graphical browsers Chrome 25, Safari 6.0.1 and Firefox 15.0.1 under Mac OS X 10.8.2 (tested on admin/content/comment logged in as admin).

mgifford’s picture

mgifford
he/him
Primary language English
commented

Is this possibly a VoiceOver issue? So far it doesn't seem like anyone has been able to reproduce this. That happens easily enough.

falcon03’s picture

falcon03 commented

@everyone: primary tabs at admin/content work great for me now. But tabs at
/admin/config/people/accounts
and at
/admin/modules
do not.

I do not have a windows testing environment right now, unfortunately.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Postponed (maintainer needs more info)

Sounds like we need a bit more information to reproduce this bug.

falcon03’s picture

falcon03 commented
Title: Primary tabs do not work when overlay module is disabled » Primary tabs could not work in certain situations due to a wrong ARIA role
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new fix_primary_tabs.patch442 bytes

@webchick: I found what was causing the problem. In seven' page.html.twig (but not in other themes or in the core template), the variable to output primary tabs was wrapped in a div which the ARIA role "tab" was assigned to. Since the "tab" ARIA role shouldn't have been used this way, Voiceover was going crazy and wasn't intercepting the primary tabs correctly. I'm attaching a patch to fix the problem.

On a side note, though, can someone tell me why tabs in seven' page.html.twig are printed from a variable called "primary_local_tasks" while elsewhere they are printed from a variable called "tabs"? This seems not consistent to me...

Also, the default page.html.twig could need some cleanup, I think; essentially it could need just some new lines to make the code more readable at a quick glance (for sighted user) and tidier (for anyone). Maybe it's a different issue, though.

jessebeach’s picture

jessebeach commented
Status: Needs review » Reviewed & tested by the community

Looks good. It's a simple fix.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.