Media Internet should use a wizard like the file_entity upload does, to allow fields and the filename to be edited

Works as advertised.

+++ b/modules/media_internet/media_internet.pages.inc
@@ -10,7 +10,18 @@
-function media_internet_add($form, &$form_state = array(), $types = NULL) {
+function media_internet_add($form, &$form_state = array(), $options = array()) {

@@ -56,130 +67,123 @@ function media_internet_add($form, &$form_state = array(), $types = NULL) {
-  if ($types) {
-    $form['#validators']['media_file_validate_types'] = array($types);
+  if ($options) {

i think $types is a better variable name here since it just ends up in 'media_file_validate_types'?

also how hard would it be to write a test that validates the correct behavior here? i see that we have zero tests with media_internet module, so that would be sweet, but not an actual blocker

I believe the use of $options is to allow for future expansion of the parameters. I agree that testing would be valuable here, but I don't want that to hold things up. I will add a tag so that we can add that later if we want.

3: 1931336-d7-4.patch queued for re-testing.

The patch no longer applies.

this seems to be working for me

This functionality was working in earlier versions of 7.x-2.x, so it looks like a bug/regression to me. There's now no longer any way to affect the properties of these files as you're adding them to the site via the media browser (you'd need to go back and edit them later).

Here's a reroll that also allows the file name to be edited on this form (just like the File Entity form does).

Also note that the patches here really require #1802026: Ajax callbacks in the media overlay cause the active tab to switch tab unexpectedly to avoid a major usability problem (since the "Web" tab, unlike "Upload", is not the default tab in the media browser).

Actually, why are these patches removing media_internet_add_validate()? This means than an invalid embed code leads to an uncaught exception rather than a friendly error message.

This patch adds it back, with code to make sure it only runs after the first step of the wizard.

While ideally I think that Media Internet should either enhance the default media element or add an element of its own, for now it's probably easiest to reuse the existing file upload wizard and simply alter the first step to replace the upload form with Media Internet's textfield.

Tested locally. 1931336-media-internet-upload-wizard-16.patch fixes issue.

Retested #16 and verified that adding internet media worked as expected.

There are a variety of additional improvements that could be done (tests, dedicated media internet widget, etc) but I'll leave those to followup issues.

Reopening this one, when I pull latest dev, the web source handling is broken. I cleared caches several times.

@aspilicious Did you also pull the latest version of File Entity?

I'm not able to duplicate any issues with the latest commit hash of Media and File Entity.