Sub-issue of #1924990: [meta] Convert all of system_config_form() to SystemConfigFormBase

CommentFileSizeAuthor
#2 rest-1925636-2.patch9.03 KBtim.plunkett
#1 rest-1925636-1.patch22.44 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
rest-1925636-1.patch22.44 KB

Includes #1921996: Convert system_config_form() to implement FormInterface as a base class. and #1925140: drupal_form_submit() does not accept FormInterface objects

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
rest-1925636-2.patch9.03 KB

This will need a reroll after #1850734: Make serialization formats configurable, but here's the patch without those other two issues.

Status: Needs review » Needs work

The last submitted patch, rest-1925636-2.patch, failed testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs work » Postponed

Postponed on #1927162: Remove REST module's UI. We need more opinions over REST UI feasibility before we waste time on this.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: tim.plunkett » Unassigned

Well then, I won't leave it on me then.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Postponed » Needs work

#1927162: Remove REST module's UI is committed.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Closed (duplicate)

The function was removed in that issue.