Links containing "callto:" are wrongly altered, making those link types unusable with mimemail.
See attached patch.
Not sure if this is a bug report. Might be a feature request as well.

Thanks again for a great module that I use practically everywhere!

CommentFileSizeAuthor
#6 mimemail-callto.patch486 bytesberliner
#4 mimemail-callto.patch486 bytesberliner
mimemail-callto.patch535 bytesberliner

Comments

sgabe’s picture

sgabe commented
Status: Active » Needs work

I think it would be a better solution to modify the pattern in the preg_match call like this:

!(mailto|callto|tel)(?=\:)!

berliner’s picture

berliner commented

Good suggestion. Help me with the pattern. What's the ?= for?
Wouldn't !(mailto|callto|tel)\:! be sufficient?

sgabe’s picture

sgabe commented

That would be a positive lookahead, which would exclude the colon from the match, though here it is unnecessary since we just searching without further processing. So !(mailto|callto|tel)\:! is enough.

berliner’s picture

berliner commented
Status: Needs work » Needs review
StatusFileSize
new mimemail-callto.patch486 bytes

Ok, thanks for the explanation. I changed the patch.

sgabe’s picture

sgabe commented
Title: Callto Links in mail body wrongly replaced » Callto links in mail body wrongly replaced
Status: Needs review » Fixed

Thank you, committed to both branches!

berliner’s picture

berliner commented
StatusFileSize
new mimemail-callto.patch486 bytes

Cool, that was quick, I just saw that there is a syntax error in the last patch (though in your commit you had corrected that).
For the sake of completeness and if anybody else stumbles upon this, I have corrected the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

fixed typos