Fix name retrieving for block plugins to fix hook_block_view_NAME_alter() [#1899772]

Not getting any result by doing hook_block_view_NAME_alter() as in BlockRenderController->viewMultiple the name is being retrieved from the entity like this

list(, $name) = $entity->id();

But id is a string, i.e. bartik.content and that would result in hook_block_view_bartik.content_alter, a simple explode is needed here

list(, $name) = explode('.', $entity->id());

Comment	File	Size	Author
#5	1899772-block_plugin_name_retrieve_fix-5.patch	5.58 KB	pcambra
#1	1899772-block_plugin_name_retrieve_fix-1.patch	748 bytes	pcambra

Comments

Comment #1

pcambra

he/him

Spanish

commented 26 January 2013 at 17:23

Issue tags:

+Needs tests

Status	File	Size
new	1899772-block_plugin_name_retrieve_fix-1.patch	748 bytes

Comment #2

pcambra

he/him

Spanish

commented 26 January 2013 at 17:45

For the tests, the best thing here is to create a new hidden module for testing that provides a block in configuration and alter it using the 3 available hooks.

Comment #3

larowlan

🇦🇺🏝.au GMT+10

commented 26 January 2013 at 20:11

Assigned:

Unassigned

» larowlan

Will handle tests

Comment #4

larowlan

🇦🇺🏝.au GMT+10

commented 13 March 2013 at 09:39

Assigned:

larowlan

» Unassigned

Sorry for squating on this

Comment #5

pcambra

he/him

Spanish

commented 21 March 2013 at 11:30

Status:	Active	» Needs review
Issue tags:	-Needs tests

Status	File	Size
new	1899772-block_plugin_name_retrieve_fix-5.patch	5.58 KB

Here's the fix with a little test module and some assertions.

I've found a naming problem though, $id and $name properties are really confusing, I've opened #1948928: ID and NAME are confusing in block_alter hooks for fixing that.