Drupal Association members fund grants that make connections all over the world.
Issue #1898464 by jenlampton, Cottser, joelpittet, steveoliver, Dustin Currie, shanethehat, cafuego, mr.baileys: toolbar.module - Convert theme_ functions to Twig.
Use Twig instead of PHPTemplate
Patch needs review
|Theme function name/template path||Conversion status|
|theme_toolbar||converted to Twig template: toolbar.html.twig|
|theme_toolbar_item||theme function removed, pre-render (
|theme_toolbar_tab_wrapper||removed and made part of toolbar template|
|theme_toolbar_tray_heading_wrapper||Removed and refactored - it was just an
|theme_toolbar_tray_wrapper||removed and made part of toolbar template|
Consolidation ideas (all completed here for performance reasons):
- Let's take the twig code from toolbar_tray_heading_wrapper and put it inside toolbar_tray_wrapper with some logic instead.
- Would be nice if we could figure out how to get rid of toolbar-item.html.twig since it doesn't do anything. (do we need it?)
- Maybe we can do the same with toolbar_tab_wrapper, too :)
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
PASSED: [[SimpleTest]]: [MySQL] 59,339 pass(es). View