diff --git a/core/modules/contextual/contextual.module b/core/modules/contextual/contextual.module index d9d20b5..4543237 100644 --- a/core/modules/contextual/contextual.module +++ b/core/modules/contextual/contextual.module @@ -33,6 +33,7 @@ function contextual_toolbar() { } $tab['contextual'] = array( + '#type' => 'toolbar_item', 'tab' => array( '#type' => 'html_tag', '#tag' => 'button', @@ -43,7 +44,6 @@ function contextual_toolbar() { 'aria-pressed' => 'false', ), ), - '#theme_wrappers' => array('toolbar_tab_wrapper'), '#wrapper_attributes' => array( 'class' => array('hidden', 'contextual-toolbar-tab'), ), diff --git a/core/modules/toolbar/templates/toolbar.html.twig b/core/modules/toolbar/templates/toolbar.html.twig new file mode 100644 index 0000000..25430d0 --- /dev/null +++ b/core/modules/toolbar/templates/toolbar.html.twig @@ -0,0 +1,43 @@ +{# +/** + * @file + * Default theme implementation for the administrative toolbar. + * + * Available variables: + * - attributes: HTML attributes for the wrapper. + * - toolbar_attributes: HTML attributes to apply to the toolbar. + * - toolbar_heading: The heading or label for the toolbar. + * - tabs: List of tabs for the toolbar. + * - attributes: HTML Attributes for the tab container. + * - link: Link or button for the menu tab. + * - trays: Toolbar tray list, each associated with a tab. Each tray in trays + * contains: + * - attributes: HTML attributes to apply to the tray. + * - label: The tray's label. + * - links: The tray menu links. + * + * @see template_preprocess_toolbar() + * + * @ingroup themeable + */ +#} + + +

{{ toolbar_heading }}

+ {% for tab in tabs %} + {{ tab.link }} + {% endfor %} + + {% for tray in trays %} + {% spaceless %} + +
+ {% if tray.label %} +

{{ tray.label }}

+ {% endif %} + {{ tray.links }} +
+ + {% endspaceless %} + {% endfor %} + diff --git a/core/modules/toolbar/toolbar.module b/core/modules/toolbar/toolbar.module index b8b0dcb..857bf7b 100644 --- a/core/modules/toolbar/toolbar.module +++ b/core/modules/toolbar/toolbar.module @@ -48,19 +48,12 @@ function toolbar_permission() { function toolbar_theme($existing, $type, $theme, $path) { $items['toolbar'] = array( 'render element' => 'element', + 'template' => 'toolbar', ); $items['toolbar_item'] = array( 'render element' => 'element', ); - $items['toolbar_tab_wrapper'] = array( - 'render element' => 'element', - ); - $items['toolbar_tray_wrapper'] = array( - 'render element' => 'element', - ); - $items['toolbar_tray_heading_wrapper'] = array( - 'render element' => 'element', - ); + return $items; } @@ -97,13 +90,10 @@ function toolbar_element_info() { ); // A toolbar item is wrapped in markup for common styling. The 'tray' - // property contains a renderable array. theme_toolbar_tab() is a light - // wrapper around the l() function. The contents of tray are rendered in - // theme_toolbar_tab(). + // property contains a renderable array. $elements['toolbar_item'] = array( '#pre_render' => array('toolbar_pre_render_item'), '#theme' => 'toolbar_item', - '#theme_wrappers' => array('toolbar_tab_wrapper'), 'tab' => array( '#type' => 'link', '#title' => NULL, @@ -218,24 +208,54 @@ function ($object) { } /** - * Returns HTML that wraps the administration toolbar. + * Prepares variables for administration toolbar templates. + * + * Default template: toolbar.html.twig. * * @param array $variables * An associative array containing: * - element: An associative array containing the properties and children of * the tray. Properties used: #children, #attributes and #bar. */ -function theme_toolbar(&$variables) { - if (!empty($variables['element']['#children'])) { - $element = $variables['element']; - $trays = ''; - foreach (element_children($element) as $key) { - $trays .= drupal_render($element[$key]['tray']); +function template_preprocess_toolbar(&$variables) { + $element = $variables['element']; + + // Prepare the toolbar attributes. + $variables['attributes'] = $element['#attributes']; + $variables['toolbar_attributes'] = new Attribute($element['#bar']['#attributes']); + $variables['toolbar_heading'] = $element['#bar']['#heading']; + + // Prepare the trays and tabs for each toolbar item. + $variables['trays'] = array(); + $variables['tabs'] = array(); + foreach (element_children($element) as $key) { + // Add the tray. + if (isset($element[$key]['tray'])) { + $variables['trays'][$key] = array( + 'links' => $element[$key]['tray'], + 'attributes' => new Attribute($element[$key]['tray']['#wrapper_attributes']), + ); + if (array_key_exists('#heading', $element[$key]['tray'])) { + $variables['trays'][$key]['label'] = $element[$key]['tray']['#heading']; + } + // Unset the tray so it doesn't render twice in the template. + unset($element[$key]['tray']); } - return '' - . '' - . '

' . $element['#bar']['#heading'] . '

' - . $element['#children'] . '' . $trays . ''; + + // Pass the wrapper attributes along. + if (array_key_exists('#wrapper_attributes', $element[$key])) { + $element[$key]['#wrapper_attributes']['class'][] = 'toolbar-tab'; + $attributes = $element[$key]['#wrapper_attributes']; + } + else { + $attributes = array('class' => array('toolbar-tab')); + } + + // Add the tab. + $variables['tabs'][$key] = array( + 'link' => $element[$key]['tab'], + 'attributes' => new Attribute($attributes), + ); } } @@ -287,99 +307,24 @@ function toolbar_pre_render_item($element) { } $element['tray']['#wrapper_attributes'] += $attributes; $element['tray']['#wrapper_attributes']['class'][] = 'toolbar-tray'; - - if (!isset($element['tray']['#theme_wrappers'])) { - $element['tray']['#theme_wrappers'] = array(); - } - // Add the standard theme_wrapper for trays. - array_unshift($element['tray']['#theme_wrappers'], 'toolbar_tray_wrapper'); - // Add the theme wrapper for the tray heading. - array_unshift($element['tray']['#theme_wrappers'], 'toolbar_tray_heading_wrapper'); } return $element; } /** - * Implements template_preprocess_HOOK(). - */ -function template_preprocess_toolbar_tab_wrapper(&$variables) { - if (!isset($variables['element']['#wrapper_attributes'])) { - $variables['element']['#wrapper_attributes'] = array(); - } - $variables['element']['#wrapper_attributes']['class'][] = 'toolbar-tab'; -} - -/** - * Returns HTML for a toolbar item. + * Implements hook_system_info_alter(). * - * This theme function only renders the tab portion of the toolbar item. The - * tray portion will be rendered later. + * Indicate that the 'page_top' region (in which the toolbar will be displayed) + * is an overlay supplemental region that should be refreshed whenever its + * content is updated. * - * @param array $variables - * An associative array containing: - * - element: An associative array containing the properties and children of - * the tray. Property used: tab. - * - * @see toolbar_pre_render_item(). - * @see theme_toolbar(). + * This information is provided for any module that might need to use it, not + * just the core Overlay module. */ -function theme_toolbar_item(&$variables) { - return drupal_render($variables['element']['tab']); -} - -/** - * Returns HTML for wrapping a toolbar tab. - * - * Toolbar tabs have a common styling and placement with the toolbar's bar area. - * - * @param array $variables - * An associative array containing: - * - element: An associative array containing the properties and children of - * the tray. Properties used: #children and #attributes. - */ -function theme_toolbar_tab_wrapper(&$variables) { - if (!empty($variables['element']['#children'])) { - $element = $variables['element']; - return '' . $element['#children'] . ''; - } -} - -/** - * Returns HTML for wrapping a toolbar tray. - * - * Used in combination with theme_toolbar_tab() to create an - * association between a link tag in the administration bar and a tray. - * - * @param array $variables - * An associative array containing: - * - element: An associative array containing the properties and children of - * the tray. Properties used: #children, #toolbar_identifier and - * #attributes. - */ -function theme_toolbar_tray_wrapper(&$variables) { - if (!empty($variables['element']['#children'])) { - $element = $variables['element']; - return '
' . $element['#children'] . '
'; - } -} - -/** - * Returns HTML for prepending a heading to a toolbar tray. - * - * @param array $variables - * An associative array containing: - * - element: An associative array containing the properties and children of - * the tray. Properties used: #children and #heading. - */ -function theme_toolbar_tray_heading_wrapper(&$variables) { - $element = $variables['element']; - if (!empty($element['#children'])) { - $heading = ''; - if (!empty($element['#heading'])) { - $heading = '

' . $element['#heading'] . '

'; - } - return $heading . $element['#children']; +function toolbar_system_info_alter(&$info, $file, $type) { + if ($type == 'theme') { + $info['overlay_supplemental_regions'][] = 'page_top'; } } @@ -394,19 +339,19 @@ function toolbar_toolbar() { '#type' => 'toolbar_item', 'tab' => array( '#type' => 'link', - '#title' => t('Back to site'), + '#title' => t('Home'), '#href' => '', '#options' => array( 'attributes' => array( - 'title' => t('Return to site content'), + 'title' => t('Home page'), 'class' => array('toolbar-icon', 'toolbar-icon-escape-admin'), 'data-toolbar-escape-admin' => TRUE, ), ), ), '#wrapper_attributes' => array( - 'class' => array('hidden'), - ), + 'class' => array('toolbar-icon', 'toolbar-icon-home'), + ), '#attached' => array( 'library' => array( array('toolbar', 'toolbar.escapeAdmin'), @@ -661,7 +606,7 @@ function toolbar_modules_uninstalled($modules) { * Implements hook_ENTITY_TYPE_update(). */ function toolbar_menu_link_update(MenuLinkInterface $menu_link) { - if ($menu_link->menu_name === 'admin') { + if ($menu_link->get('menu_name') === 'admin') { _toolbar_clear_user_cache(); } }