In the _print_pdf_wkhtmltopdf function (print_pdf.pages.inc), when an error occurs and a PDF isn't produced the user should go to $print['url'], rather than the non-existent $meta['url'].

Patch to be attached in the next comment.

CommentFileSizeAuthor
#1 print-no-var-named-meta-1896668-1.patch439 bytessiliconmeadow

Comments

siliconmeadow’s picture

siliconmeadow commented
StatusFileSize
new print-no-var-named-meta-1896668-1.patch439 bytes

Patch as mentioned.

siliconmeadow’s picture

siliconmeadow commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Whoops. I'm such a D7 n00b!

mwesthof’s picture

mwesthof commented

I was thinking the same.
The code change works for me.

The bug causes:

Notice: Undefined variable: meta in _print_pdf_wkhtmltopdf() line 434 of ... /sites/all/modules/contrib/print/print_pdf/print_pdf.pages.inc).

and then redirects to the home page.

The code change changes the behaviour of the goto to stay on the current page.

simon georges’s picture

simon georges commented
Status: Needs review » Reviewed & tested by the community
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch!

http://drupalcode.org/project/print.git/commit/c2aedb2

mwesthof’s picture

mwesthof commented

Thanks for the patch and thanks for the commit! Pretty smooth bug squash. Awesome!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.